Remove libs message about ACPs from triagebot #111679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
|
cc @rust-lang/libs-api |
The libs team is currently reworking the ACP process and we don't want to encourage people to submit new ACPs in the meantime.
Amanieu
force-pushed
the
triagebot-remove-acp
branch
from
3e25913 to
67c0cfe
Compare
fee1-dead
reviewed
May 17, 2023
Comment on lines
-378
to
-387
| If this PR contains changes to any `rust-lang/rust` public library APIs then \ | ||
| please comment with `@rustbot label +T-libs-api -T-libs` to tag it \ | ||
| appropriately. If this PR contains changes to any unstable APIs please edit \ | ||
| the PR description to add a link to the relevant [API Change \ | ||
| Proposal](https://std-dev-guide.rust-lang.org/feature-lifecycle/api-change-proposals.html) \ | ||
| or [create one](https://github.com/rust-lang/libs-team/issues/new?assignees=&labels=api-change-proposal%2C+T-libs-api&template=api-change-proposal.md&title=%28My+API+Change+Proposal%29) \ | ||
| if you haven't already. If you're unsure where your change falls no worries, \ | ||
| just leave it as is and the reviewer will take a look and make a decision to \ | ||
| forward on if necessary. | ||
|
|
There was a problem hiding this comment.
Wouldn't it still be nice to tell people to appropriately add labels? (would it be fine to only remove the sentence on ACPs?)
There was a problem hiding this comment.
We'll be revising how we use the labels and categorize PRs, so this will be updated as well. For now this PR is just removing outdated information while we figure out what the right process/info should be.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#110884 (Support RISC-V unaligned-scalar-mem target feature) - rust-lang#111160 (Update serde in workspace and non-synced dependencies) - rust-lang#111168 (Specialize ToString implementation for fmt::Arguments) - rust-lang#111527 (add examples of port 0 binding behavior) - rust-lang#111561 (Include better context for "already exists" error in compiletest) - rust-lang#111633 (Avoid `&format("...")` calls in error message code.) - rust-lang#111679 (Remove libs message about ACPs from triagebot) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libs team is currently reworking the ACP process and we don't want to encourage people to submit new ACPs in the meantime.