Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libs message about ACPs from triagebot #111679

Merged
merged 1 commit into from
May 18, 2023
Merged

Remove libs message about ACPs from triagebot #111679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,31 +371,6 @@ cc = ["@GuillaumeGomez"]
message = "Some changes might have occurred in exhaustiveness checking"
cc = ["@Nadrieril"]

[mentions."library"]
message = """
Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any `rust-lang/rust` public library APIs then \
please comment with `@rustbot label +T-libs-api -T-libs` to tag it \
appropriately. If this PR contains changes to any unstable APIs please edit \
the PR description to add a link to the relevant [API Change \
Proposal](https://std-dev-guide.rust-lang.org/feature-lifecycle/api-change-proposals.html) \
or [create one](https://github.com/rust-lang/libs-team/issues/new?assignees=&labels=api-change-proposal%2C+T-libs-api&template=api-change-proposal.md&title=%28My+API+Change+Proposal%29) \
if you haven't already. If you're unsure where your change falls no worries, \
just leave it as is and the reviewer will take a look and make a decision to \
forward on if necessary.

Comment on lines -378 to -387
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it still be nice to tell people to appropriately add labels? (would it be fine to only remove the sentence on ACPs?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be revising how we use the labels and categorize PRs, so this will be updated as well. For now this PR is just removing outdated information while we figure out what the right process/info should be.

Examples of `T-libs-api` changes:

* Stabilizing library features
* Introducing insta-stable changes such as new implementations of existing \
stable traits on existing stable types
* Introducing new or changing existing unstable library APIs (excluding \
permanently unstable features / features without a tracking issue)
* Changing public documentation in ways that create new stability guarantees
* Changing observable runtime behavior of library APIs
"""

[mentions."src/librustdoc/clean/types.rs"]
cc = ["@camelid"]

Expand Down