Skip to content

Migrate GUI colors test to original CSS color format #112274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2023
Merged

Migrate GUI colors test to original CSS color format #112274

merged 2 commits into from
Jun 4, 2023

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #111459.

The update for browser-ui-test version is because for hex color conversions, it used a precision of 1 instead of 2, which was problematic.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 4, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 4, 2023

📌 Commit d67e00e has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2023
@bors
Auto merge of rust-lang#112282 - matthiaskrgr:rollup-1g9w02p, r=matth…
101fa90 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#112247 (rust-lld: add rpath entry to the correct `lib` folder)
 - rust-lang#112274 (Migrate GUI colors test to original CSS color format)
 - rust-lang#112277 (Don't require the output from libtest to be valid UTF-8)

Failed merges:

 - rust-lang#112251 (rustdoc: convert `if let Some()` that always matches to variable)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 97b702f into rust-lang:master Jun 4, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 4, 2023
@GuillaumeGomez GuillaumeGomez deleted the migrate-gui-test-color-11 branch June 5, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @notriddle @bors @rustbot