Update field-offset and enable unstable_offset_of #112298
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This enables usage of the offset_of!() macro in the compiler, through the wrappers in memoffset and then in field-offset.
est31
force-pushed
the
update_field_offset
branch
from
cbd4902 to
b048396
Compare
rustbot
added
the
A-query-system
| @@ -25,5 +24,8 @@ rustc_span = { path = "../rustc_span" } | |||
| thin-vec = "0.2.12" | |||
| tracing = "0.1" | |||
|
|
|||
| # Not used directly, but included to enable the unstable_offset_of feature | |||
There was a problem hiding this comment.
is the comment still accurate? this crate had the dep before
There was a problem hiding this comment.
Btw, unstable_const feature lost, maybe it needed?
There was a problem hiding this comment.
Grep for memoffset, there is no results.
Before it was included to enable the unstable_const feature, which <enabled usage of the pointer::offset_from function, but that function is not used if unstable_offset_of is enabled as that directly uses offset_of!().
The offset_of_tuple macro still doesn't use offset_of so unstable_const does something to the public API of memoffset still, but that macro is not used I think neither by rustc nor by any of its deps, at least that's my impression.
In other words, enabling unstable_const makes no sense at this point.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112297 (bootstrap: Disallow `--exclude test::std`) - rust-lang#112298 (Update field-offset and enable unstable_offset_of) - rust-lang#112335 (ci: Upgrade loongarch64-linux-gnu GCC to 13.1.0) - rust-lang#112413 (Adjust span labels for `HIDDEN_GLOB_REEXPORTS`) - rust-lang#112483 (Add deprecation warning to python versions <3.6 in x.py) r? `@ghost` `@rustbot` modify labels: rollup
This makes the compiler use the builtin
offset_of!()macro, through the wrappers in memoffset and then in field-offset.cc #111839