Add deprecation warning to python versions <3.6 in x.py #112483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soft deprecate old python versions to give users a warning that eventually it may not be supported.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
We could also create a dedicated issue for python version issues and link that in the error message. |
|
I'm OK with this, and not sure that the env variable is entirely useful, but seems fine to keep it. We can revisit this if there are concerns or we encounter too many warnings in practice. @bors r+ rollup |
bors
added
S-waiting-on-bors
I think I may have misunderstood your comment #110439 (comment) since you can disable |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#112297 (bootstrap: Disallow `--exclude test::std`) - rust-lang#112298 (Update field-offset and enable unstable_offset_of) - rust-lang#112335 (ci: Upgrade loongarch64-linux-gnu GCC to 13.1.0) - rust-lang#112413 (Adjust span labels for `HIDDEN_GLOB_REEXPORTS`) - rust-lang#112483 (Add deprecation warning to python versions <3.6 in x.py) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced based on conversation on Zulip. This is a repeat of #110439 with two changes:
The min to not get the warning is set to 3.6 because that's a fairly recent "old" version (went EOL in 2021) and it's the first version to support useful modern features like f-strings and type hints.
cc @Nilstrieb (author of #110439) and @Mark-Simulacrum (reviewer of that PR)