Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print omitted frames count for short backtrace mode #112843

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Print omitted frames count for short backtrace mode #112843

merged 2 commits into from
Jul 31, 2023

Conversation

chenyukang
Copy link
Member

Fixes #111730

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 20, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

klensy
klensy reviewed Jun 20, 2023
View reviewed changes
library/std/Cargo.toml Outdated Show resolved Hide resolved
m-ou-se
m-ou-se reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@m-ou-se m-ou-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me. Just two suggestions:

library/std/src/sys_common/backtrace.rs Outdated Show resolved Hide resolved
library/std/src/sys_common/backtrace.rs Outdated Show resolved Hide resolved
@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
@chenyukang chenyukang mentioned this pull request Jun 21, 2023
Merged
@chenyukang chenyukang force-pushed the yukang-more-on-backtrace branch 2 times, most recently from 41f4ee4 to 9378c73 Compare June 29, 2023 00:47
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2023
@bors
Copy link
Contributor

bors commented Jul 3, 2023

☔ The latest upstream changes (presumably #113046) made this pull request unmergeable. Please resolve the merge conflicts.

@chenyukang
Copy link
Member Author

@rustbot ready

@bors
Copy link
Contributor

bors commented Jul 3, 2023

☔ The latest upstream changes (presumably #113176) made this pull request unmergeable. Please resolve the merge conflicts.

@chenyukang
Copy link
Member Author

@rustbot ready

@workingjubilee
Copy link
Member

Seems m-ou-se's comments were addressed!
@bors r+

@bors
Copy link
Contributor

bors commented Jul 26, 2023

📌 Commit 809ef24 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 26, 2023
@matthiaskrgr
Rollup merge of rust-lang#112843 - chenyukang:yukang-more-on-backtrac…
f4a473a 
…e, r=workingjubilee

Print omitted frames count for short backtrace mode

Fixes rust-lang#111730
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 26, 2023
Closed
@chenyukang
Copy link
Member Author

@bors r=@workingjubilee

@bors
Copy link
Contributor

bors commented Jul 30, 2023

📌 Commit 2eb2f17db146e2cbd94685c9f604b004da10a75a has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
@bors
Copy link
Contributor

bors commented Jul 30, 2023

⌛ Testing commit 2eb2f17db146e2cbd94685c9f604b004da10a75a with merge 5f486f777c84833a52a30754663621505541185f...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 30, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2023
@workingjubilee
Copy link
Member

Hmm, one more go. If this still doesn't pass then I think we should reassess this and approach it more systematically.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 30, 2023

📌 Commit 7b3d1b7 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
@bors
Copy link
Contributor

bors commented Jul 30, 2023

⌛ Testing commit 7b3d1b7 with merge d4145ee...

@bors
Copy link
Contributor

bors commented Jul 31, 2023

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing d4145ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2023
@bors bors merged commit d4145ee into rust-lang:master Jul 31, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 31, 2023
@bors bors mentioned this pull request Jul 31, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d4145ee): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 6.1% [6.1%, 6.1%] 1
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.4% [3.0%, 4.1%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 653.169s -> 653.113s (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 31, 2023
@workingjubilee
Copy link
Member

That's a really wild shift...

@chenyukang
Copy link
Member Author

Hmm, one more go. If this still doesn't pass then I think we should reassess this and approach it more systematically.

@bors r+

Yep, the hard thing for strip backtrace message is different arch may have trivial difference, and I don't have a x64_linux in my local env :(

@chenyukang
Copy link
Member Author

That's a really wild shift...

Interesting...
But my code changes is only related error handling, it should not be on the hot path.
we also have benchmark testing on errors?

@rylev
Copy link
Member

rylev commented Aug 5, 2023

Seems like the start of noise:

Screenshot 2023-08-05 at 15 14 49

@rustbot label: perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klensy klensy klensy left review comments

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@workingjubilee workingjubilee

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Add N frames omitted in backtrace frames
9 participants
@chenyukang @rustbot @rust-log-analyzer @bors @workingjubilee @rust-timer @rylev @m-ou-se @klensy