-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print omitted frames count for short backtrace mode #112843
Conversation
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. Just two suggestions:
41f4ee4
to
9378c73
Compare
This comment has been minimized.
This comment has been minimized.
@rustbot ready |
☔ The latest upstream changes (presumably #113046) made this pull request unmergeable. Please resolve the merge conflicts. |
d5407b1
to
9f72cb4
Compare
@rustbot ready |
☔ The latest upstream changes (presumably #113176) made this pull request unmergeable. Please resolve the merge conflicts. |
9f72cb4
to
809ef24
Compare
@rustbot ready |
Seems m-ou-se's comments were addressed! |
…e, r=workingjubilee Print omitted frames count for short backtrace mode Fixes rust-lang#111730
298ea5d
to
2eb2f17
Compare
📌 Commit 2eb2f17db146e2cbd94685c9f604b004da10a75a has been approved by It is now in the queue for this repository. |
⌛ Testing commit 2eb2f17db146e2cbd94685c9f604b004da10a75a with merge 5f486f777c84833a52a30754663621505541185f... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
2eb2f17
to
7b3d1b7
Compare
Hmm, one more go. If this still doesn't pass then I think we should reassess this and approach it more systematically. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d4145ee): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 653.169s -> 653.113s (-0.01%) |
That's a really wild shift... |
Yep, the hard thing for strip backtrace message is different arch may have trivial difference, and I don't have a x64_linux in my local env :( |
Interesting... |
Seems like the start of noise: @rustbot label: perf-regression-triaged |
Fixes #111730