-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo update #113046
cargo update #113046
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
uh, maybe that's just from github actions being weird, let's try again. could also be a result of the update. |
tracing is stuck locking a mutex :( |
I downgraded tracing, the cause of the deadlock. I'll take a look at that issue later, but this is unblocked now. |
This comment has been minimized.
This comment has been minimized.
I've opened tokio-rs/tracing#2635 for the tracing issue. |
The diagnostics derive proc macro output changes are probably from the syn update. I'm gonna keep syn on the older version for now, we can update that in a separate PR since it isn't entirely trivial to bless. |
f3b7ac1
to
1f124e2
Compare
☔ The latest upstream changes (presumably #113120) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me with a rebase |
Some changes occurred in src/tools/cargo cc @ehuss |
accidentally rebased too much |
@bors r+ rollup=never |
📌 Commit ddf613a585aaf229c59a5e783840e7c6b174575c has been approved by It is now in the queue for this repository. |
⌛ Testing commit ddf613a585aaf229c59a5e783840e7c6b174575c with merge 7ad85838a63f96ee28741a1589a700413073dbbb... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #113260) made this pull request unmergeable. Please resolve the merge conflicts. |
There's currently a deadlock with tracing when RUSTC_LOG is enabled. Downgrade tracing-core for now to avoid blocking the other updates. syns upgrades cause some nontrivial changes in the diagnostics derive tests, which are best dealt with in another PR.
The outline-atomics support in compiler_builtins messed up and wasn't limited to linux only. https://github.com/rust-lang/compiler-builtins/pull/532/files#r1249354225
@bors r=Mark-Simulacrum p=15 this is really bitrotty |
☀️ Test successful - checks-actions |
Finished benchmarking commit (839e9a6): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 660.214s -> 668.087s (1.19%) |
bitmaps IncrUnchanged |
The new version was already added to the tree as an indirect dependency in rust-lang#113046, but now our direct dependents are using it too.
Upgrade to indexmap 2.0.0 The new version was already added to the tree as an indirect dependency in rust-lang#113046, but now our direct dependents are using it too.
1.72.0 will be a release that won't be too interesting, so I think it's a great opportunity to mention this PR in the blog post (or even release notes). Saying that the compiler updated dependencies and got a free 1% speedup for incremental compilations, reminding people to update their own deps :) |
#112865 with the tidy exemptions and tracing and syn 2 not upgraded
Additional deps:
equivalent: indexmap
errno: through rustix
errno-dragonfly: errno
nu-ansi-term: tracing
overload: nu-ansi-term
r? Mark-Simulacrum