-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable zlib in LLVM on aarch64-apple-darwin #112931
Conversation
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
Probably a better reviewer for this change |
Let's bump the file. r=me with that done. |
@bors r=Mark-Simulacrum |
⌛ Testing commit d43131b with merge 2e39d68a758dda553f52679ad332893b6acd9ea1... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
It's trying to download the CI LLVM of this commit, chicken and egg... downloading https://ci-artifacts.rust-lang.org/rustc-builds/2e39d68a758dda553f52679ad332893b6acd9ea1/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
curl: (22) The requested URL returned error: 404 Not Found
error: failed to download llvm from ci
help: old builds get deleted after a certain time
help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml: |
Enable zlib in LLVM on aarch64-apple-darwin Works on macOS 13.4, Xcode version 14.3.1.0.1.1683849156 This was disabled in rust-lang#75500 on Apple Silicon Developer Transition Kit, but Apple appears to have fixed their zlib now
@bors retry |
Hopefully it should work now that #113323 is merged. |
Enable zlib in LLVM on aarch64-apple-darwin Works on macOS 13.4, Xcode version 14.3.1.0.1.1683849156 This was disabled in rust-lang#75500 on Apple Silicon Developer Transition Kit, but Apple appears to have fixed their zlib now
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112931 (Enable zlib in LLVM on aarch64-apple-darwin) - rust-lang#113158 (tests: unset `RUSTC_LOG_COLOR` in a test) - rust-lang#113173 (CI: include workflow name in concurrency group) - rust-lang#113335 (Reveal opaques in new solver) - rust-lang#113390 (CGU formation tweaks) - rust-lang#113399 (Structurally normalize again for byte string lit pat checking) - rust-lang#113412 (Add basic types to SMIR) r? `@ghost` `@rustbot` modify labels: rollup
Works on macOS 13.4, Xcode version 14.3.1.0.1.1683849156
This was disabled in #75500 on Apple Silicon Developer Transition Kit, but Apple appears to have fixed their zlib now