Enable zlib in LLVM on aarch64-apple-darwin #112931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
|
Probably a better reviewer for this change |
Let's bump the file. r=me with that done. |
|
@bors r=Mark-Simulacrum |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d43131b with merge 2e39d68a758dda553f52679ad332893b6acd9ea1... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
It's trying to download the CI LLVM of this commit, chicken and egg... downloading https://ci-artifacts.rust-lang.org/rustc-builds/2e39d68a758dda553f52679ad332893b6acd9ea1/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
curl: (22) The requested URL returned error: 404 Not Found
error: failed to download llvm from ci
help: old builds get deleted after a certain time
help: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml: |
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Jun 27, 2023
Enable zlib in LLVM on aarch64-apple-darwin Works on macOS 13.4, Xcode version 14.3.1.0.1.1683849156 This was disabled in rust-lang#75500 on Apple Silicon Developer Transition Kit, but Apple appears to have fixed their zlib now
|
@bors retry |
bors
added
S-waiting-on-bors
|
Hopefully it should work now that #113323 is merged. |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jul 8, 2023
Enable zlib in LLVM on aarch64-apple-darwin Works on macOS 13.4, Xcode version 14.3.1.0.1.1683849156 This was disabled in rust-lang#75500 on Apple Silicon Developer Transition Kit, but Apple appears to have fixed their zlib now
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 8, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112931 (Enable zlib in LLVM on aarch64-apple-darwin) - rust-lang#113158 (tests: unset `RUSTC_LOG_COLOR` in a test) - rust-lang#113173 (CI: include workflow name in concurrency group) - rust-lang#113335 (Reveal opaques in new solver) - rust-lang#113390 (CGU formation tweaks) - rust-lang#113399 (Structurally normalize again for byte string lit pat checking) - rust-lang#113412 (Add basic types to SMIR) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on macOS 13.4, Xcode version 14.3.1.0.1.1683849156
This was disabled in #75500 on Apple Silicon Developer Transition Kit, but Apple appears to have fixed their zlib now