Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 4, 2023

This should avoid CI breakage when the LLVM stamp is updated, and also it will avoid an unnecessary LLVM download from CI.

r? @jyn514

This should avoid CI breakage when the LLVM stamp is updated, and also it will avoid an unnecessary LLVM download from CI.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 4, 2023
@jyn514
Copy link
Member

jyn514 commented Jul 4, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2023

📌 Commit be99bb9 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2023
@Kobzol
Copy link
Member Author

Kobzol commented Jul 4, 2023

I'll also start a try build, we should see in ~hour if it works, to avoid an unnecessarily failed merge.

@bors try

@bors
Copy link
Collaborator

bors commented Jul 4, 2023

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@Kobzol
Copy link
Member Author

Kobzol commented Jul 4, 2023

Ok, apparently I will not.

@rust-log-analyzer

This comment has been minimized.

@jyn514
Copy link
Member

jyn514 commented Jul 4, 2023

@bors rollup=iffy

@Noratrieb
Copy link
Member

Noratrieb commented Jul 4, 2023

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

For context, bors has a funny bug where it insta pushes a PR to master if you r+ during a try build.

Oh nevermind, this is older than knowledge of the bug, this appears to be a normal message. Interesting.

@bors
Copy link
Collaborator

bors commented Jul 5, 2023

⌛ Testing commit be99bb9 with merge 3561b7a159440a6c68521b4f328c88750bc69945...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jul 5, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2023
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2023
@lqd lqd mentioned this pull request Jul 5, 2023
@Kobzol
Copy link
Member Author

Kobzol commented Jul 5, 2023

@rustbot ready

I realized that by default the tests won't run in a try build, so we might as well just retry the merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2023
@Kobzol
Copy link
Member Author

Kobzol commented Jul 6, 2023

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented Jul 6, 2023

📌 Commit 12b75fe has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2023
@bors
Copy link
Collaborator

bors commented Jul 6, 2023

⌛ Testing commit 12b75fe with merge c4c84df...

@bors
Copy link
Collaborator

bors commented Jul 6, 2023

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing c4c84df to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2023
@bors bors merged commit c4c84df into rust-lang:master Jul 6, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 6, 2023
@Kobzol Kobzol deleted the pgo-script-llvm-ci branch July 6, 2023 15:46
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c4c84df): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.3% [2.5%, 4.0%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.3% [2.5%, 4.0%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.2%, 3.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.625s -> 657.995s (0.21%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants