Make sure to include default en-US ftl resources for rustc_error crate
#112973
Conversation
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
| rustc_attr::DEFAULT_LOCALE_RESOURCE, | ||
| rustc_borrowck::DEFAULT_LOCALE_RESOURCE, | ||
| rustc_builtin_macros::DEFAULT_LOCALE_RESOURCE, | ||
| rustc_codegen_ssa::DEFAULT_LOCALE_RESOURCE, |
There was a problem hiding this comment.
Side-note: It really sucks that we have to keep this in sync and that nothing detects when it's missing a crate entry -- cc @davidtwco
There was a problem hiding this comment.
Seems except rustc_codegen_gcc/messages.ftl and rustc_codegen_llvm/messages.ftl, all other messages.ftl should be included here.
Maybe we need a tidy check?
There was a problem hiding this comment.
@chenyukang: Codegen backends use an alternative way of injecting their fluent bundles: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/trait.CodegenBackend.html#tymethod.locale_resource
There was a problem hiding this comment.
Oops, I misread your message. I guess this could be implemented as a tidy check as a first pass, yeah.
|
@bors r=jyn514 |
bors
added
S-waiting-on-bors
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#111087 (Implement `Sync` for `mpsc::Sender`) - rust-lang#112763 (Bump compiler_builtins) - rust-lang#112963 (Stop bubbling out hidden types from the eval obligation queries) - rust-lang#112965 (Don't emit same goal as input during `wf::unnormalized_obligations`) - rust-lang#112973 (Make sure to include default en-US ftl resources for `rustc_error` crate) - rust-lang#112981 (Fix return type notation errors with -Zlower-impl-trait-in-trait-to-assoc-ty) - rust-lang#112983 (Fix return type notation associated type suggestion when -Zlower-impl-trait-in-trait-to-assoc-ty) - rust-lang#112986 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup
6 participants
Fixes #112928