Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type notation errors with -Zlower-impl-trait-in-trait-to-assoc-ty #112981

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

spastorino
Copy link
Member

This just adjust the way we check for RPITITs and uses the new helper method to do the "old" and "new" check at once.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 23, 2023
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me w/ ci is green

@spastorino
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jun 23, 2023

📌 Commit d77e55b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2023
@spastorino
Copy link
Member Author

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2023
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111087 (Implement `Sync` for `mpsc::Sender`)
 - rust-lang#112763 (Bump compiler_builtins)
 - rust-lang#112963 (Stop bubbling out hidden types from the eval obligation queries)
 - rust-lang#112965 (Don't emit same goal as input during `wf::unnormalized_obligations`)
 - rust-lang#112973 (Make sure to include default en-US ftl resources for `rustc_error` crate)
 - rust-lang#112981 (Fix return type notation errors with -Zlower-impl-trait-in-trait-to-assoc-ty)
 - rust-lang#112983 (Fix return type notation associated type suggestion when -Zlower-impl-trait-in-trait-to-assoc-ty)
 - rust-lang#112986 (Update cargo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4a17552 into rust-lang:master Jun 24, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2023
…-errors

 Replace RPITIT current impl with new strategy that lowers as a GAT

This PR replaces the current implementation of RPITITs with the new implementation that we had under -Zlower-impl-trait-in-trait-to-assoc-ty flag that lowers the RPIT as a GAT on the trait and on the impls that implement that trait.

Opening this PR as a draft because this goes after rust-lang#112682, ~rust-lang#112981~ and ~rust-lang#112983~.
As soon as those are merged, I can rebase and we should run perf, crater and test a lot.

r? `@compiler-errors`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants