-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rustc_on_unimplemented
std-agnostic
#113054
Make rustc_on_unimplemented
std-agnostic
#113054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit and this is good to go
b6c5333
to
48544c1
Compare
Addressed nit and removed superfluous trailing commas to maintain consistency. @rustbot ready |
@bors r+ rollup |
⌛ Testing commit 48544c1 with merge f91afc7a74b5525c28c1ad59afbda7e2e5c95501... |
…nted`-std-agnostic, r=WaffleLapkin Make `rustc_on_unimplemented` std-agnostic See rust-lang#112923 r? `@WaffleLapkin`
…nted`-std-agnostic, r=WaffleLapkin Make `rustc_on_unimplemented` std-agnostic See rust-lang#112923 r? ``@WaffleLapkin``
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112670 (privacy: Type privacy lints fixes and cleanups) - rust-lang#112929 (Test that we require implementing trait items whose bounds don't hold in the current impl) - rust-lang#113054 (Make `rustc_on_unimplemented` std-agnostic) - rust-lang#113137 (don't suggest `move` for borrows that aren't closures) - rust-lang#113139 (style-guide: Clarify let-else further) - rust-lang#113140 (style-guide: Add an example of formatting a multi-line attribute) - rust-lang#113143 (style-guide: Narrow guidance about references and dereferencing) r? `@ghost` `@rustbot` modify labels: rollup
See #112923
r? @WaffleLapkin