-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #113146
Rollup of 7 pull requests #113146
Conversation
Use a boolean constant parameter instead. Also turn some methods on `DefIdVisitor` into associated constants.
…ility This commit reverts a change made in rust-lang#111425. It was believed that this change was necessary for implementing type privacy lints, but rust-lang#111801 showed that it was not necessary. Quite opposite, the revert fixes some issues.
… of effect on impls
Give some additional examples with multi-line patterns. Make it clearer to go on to the next case if the conditions aren't met.
We already say to format attributes like functions, but we didn't have an example of formatting a multi-line attribute.
The style guide advises "prefer dereferencing to taking references", but doesn't give guidance on when that "preference" should get overridden by other considerations. Give an example of when it's fine to ignore that advice.
privacy: Type privacy lints fixes and cleanups See individual commits. Follow up to rust-lang#111801.
…doesnt_wanna_be_impld, r=compiler-errors Test that we require implementing trait items whose bounds don't hold in the current impl I initially tried to make most of these pass, but that's a big can of worms, so I'm just adding them as tests, considering we have no tests for these things.
…nted`-std-agnostic, r=WaffleLapkin Make `rustc_on_unimplemented` std-agnostic See rust-lang#112923 r? `@WaffleLapkin`
…=compiler-errors don't suggest `move` for borrows that aren't closures fixes rust-lang#113087
…e, r=calebcartwright style-guide: Clarify let-else further Give some additional examples with multi-line patterns. Make it clearer to go on to the next case if the conditions aren't met.
…ulti-line-attribute, r=calebcartwright style-guide: Add an example of formatting a multi-line attribute We already say to format attributes like functions, but we didn't have an example of formatting a multi-line attribute.
…reference-guidance, r=calebcartwright style-guide: Narrow guidance about references and dereferencing The style guide advises "prefer dereferencing to taking references", but doesn't give guidance on when that "preference" should get overridden by other considerations. Give an example of when it's fine to ignore that advice.
@bors r+ rollup=never p=7j |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 75726cae37 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (0a32ca9): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.556s -> 661.126s (0.24%) |
Successful merges:
rustc_on_unimplemented
std-agnostic #113054 (Makerustc_on_unimplemented
std-agnostic)move
for borrows that aren't closures #113137 (don't suggestmove
for borrows that aren't closures)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup