-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set channel = nightly
in dist profile
#113185
Conversation
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
I set Up to this point, I don't think the profiles have affected me at all, because I use That said, I think you're right that I don't want those 3 dev-enabled settings. |
I agree - not having one-size-fits-all settings is exactly the problem that profiles try to solve :) the idea is that if the global defaults change in the future, the rust/src/bootstrap/defaults/config.dist.toml Lines 1 to 19 in 85c4ea0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This avoids some channel-specific defaults leaking into local installs. It also makes it easier to set options for compiler/library/codegen profiles in the future, since they can be gated off channel instead of being duplicated between all three files.
Sounds and looks good to me. If you want another opinion/review on this, feel free to re-assign. r=me otherwise.
👍 @bors r=ozkanonur rollup |
Set `channel = nightly` in dist profile This avoids some channel-specific defaults leaking into local installs. It also makes it easier to set options for compiler/library/codegen profiles in the future, since they can be gated off `channel` instead of being duplicated between all three files. Here are the exact things `channel` controls today: https://github.com/rust-lang/rust/blob/68d458bb402b873b9ae80423710c2672967479df/src/bootstrap/llvm.rs#L466-L470 https://github.com/rust-lang/rust/blob/85c4ea0138fcca2e8cf4515a063cd3b762d64aec/src/bootstrap/config.rs#L1374-L1375 https://github.com/rust-lang/rust/blob/85c4ea0138fcca2e8cf4515a063cd3b762d64aec/src/bootstrap/config.rs#L1464-L1465 `@cuviper` i expect you don't want any of those to be set in distro builds, right?
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113072 (str docs: remove "Basic usage" text where not useful) - rust-lang#113153 (make HashMap::or_insert_with example more simple) - rust-lang#113185 (Set `channel = nightly` in dist profile) - rust-lang#113186 (document that the panic in collect_intra_doc_links is load-bearing) - rust-lang#113187 (No need to distinguish `LocalTy` from `Ty`) - rust-lang#113189 (compiletest: Only trim the end of process output) - rust-lang#113191 (Update browser-ui-test version and improve GUI test) - rust-lang#113206 (User may want to skip tidy check sometimes) r? `@ghost` `@rustbot` modify labels: rollup
This avoids some channel-specific defaults leaking into local installs. It also makes it easier to set options for compiler/library/codegen profiles in the future, since they can be gated off
channel
instead of being duplicated between all three files.Here are the exact things
channel
controls today:rust/src/bootstrap/llvm.rs
Lines 466 to 470 in 68d458b
rust/src/bootstrap/config.rs
Lines 1374 to 1375 in 85c4ea0
rust/src/bootstrap/config.rs
Lines 1464 to 1465 in 85c4ea0
@cuviper i expect you don't want any of those to be set in distro builds, right?