No need to distinguish LocalTy from Ty
#113187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
b-naber
approved these changes
Jun 30, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 30, 2023
No need to distinguish `LocalTy` from `Ty` I think the distinction between `decl_ty` and `revealed_ty` was from when you were allowed to put `impl Trait` in let bindings... I don't think we need that anymore, and it makes typeck that much more confusing 😆 Side-note: I don't know why we store this in a separate field [`locals`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_typeck/struct.Inherited.html#structfield.locals) in `Inherited`, rather than just the `TypeckResults`... Might look into changing that next.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 30, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113072 (str docs: remove "Basic usage" text where not useful) - rust-lang#113153 (make HashMap::or_insert_with example more simple) - rust-lang#113185 (Set `channel = nightly` in dist profile) - rust-lang#113186 (document that the panic in collect_intra_doc_links is load-bearing) - rust-lang#113187 (No need to distinguish `LocalTy` from `Ty`) - rust-lang#113189 (compiletest: Only trim the end of process output) - rust-lang#113191 (Update browser-ui-test version and improve GUI test) - rust-lang#113206 (User may want to skip tidy check sometimes) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the distinction between
decl_tyandrevealed_tywas from when you were allowed to putimpl Traitin let bindings... I don't think we need that anymore, and it makes typeck that much more confusing 😆Side-note: I don't know why we store this in a separate field
localsinInherited, rather than just theTypeckResults... Might look into changing that next.