Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #113488

Merged
merged 49 commits into from
Jul 9, 2023
Merged

update Miri #113488

merged 49 commits into from
Jul 9, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 8, 2023

No description provided.

oli-obk and others added 30 commits June 29, 2023 07:08
@oli-obk
Bashy Mc Bashface
ccb3328
@oli-obk
Checking for a cached value without having a cache is useless
2039e7c
@bors
Auto merge of rust-lang#2947 - oli-obk:gha_mk_pr, r=RalfJung
d061edd 
Try to fix cronjob PR creation

The main tests use `bash` several times, maybe that is the issue here, too?
@RalfJung
cronjob auto-PR: make sure we are on a branch
5fa7403
@bors
Auto merge of rust-lang#2948 - RalfJung:cron, r=RalfJung
9e49f53 
cronjob auto-PR: make sure we are on a branch

Also run this every hour to speed up testing
@RalfJung
cronjob auto-PR: fetch more of the history
04db677
@RalfJung
CI cleanup
7adf8dd
@bors
Auto merge of rust-lang#2949 - RalfJung:cron, r=RalfJung
918f393 
cronjob auto-PR: fetch more of the history
@icewind1991
cargo-miri: better error message when RUSTC is not set
cc4670f
@RalfJung
cron auto-PR: need to set upstream branch
f2ce230
@bors
Auto merge of rust-lang#2951 - rust-lang:cron, r=RalfJung
a6eb25a 
cron auto-PR: need to set upstream branch
@bors
Auto merge of rust-lang#2950 - icewind1991:cargo-miri-rustc-error, r=…
7d12d2f 
…RalfJung

cargo-miri: better error message when RUSTC is not set

Currently, when running `cargo-miri` instead of `cargo miri` you get a very confusing.

```
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NotPresent', src/tools/miri/cargo-miri/src/main.rs:83:41
```

error. This replaces that with a message telling them to use `cargo miri`
@RalfJung
cronjob auto-PR: try to fix setting the remote branch
32168b7
@bors
Auto merge of rust-lang#2952 - RalfJung:cron, r=RalfJung
0bf13a4 
cronjob auto-PR: try to fix setting the remote branch
@RalfJung
sadly 'gh' doesnt support all git upstream branch configs
2c5e076
@bors
Auto merge of rust-lang#2953 - RalfJung:cron, r=RalfJung
f037471 
sadly 'gh' doesnt support all git upstream branch configs
@RalfJung
more CI yml cleanup
4c7fbf8
@RalfJung
can't seem to avoid repeating the branch name...
352180b
@bors
Auto merge of rust-lang#2954 - RalfJung:cron, r=RalfJung
7d63d70 
cron auto-PR: can't seem to avoid repeating the branch name...
Preparing for merge from rustc
17e17e1
Merge from rustc
1505dd8
fmt
707afc3
@oli-obk
Silence clippy on FIXME'd code and fix the new lints otherwise
6a21b2d
@bors
Auto merge of rust-lang#2955 - rust-lang:rustup2023-07-03, r=oli-obk
a8b6ec1 
Automatic sync from rustc
@RalfJung
send link to PR to Zulip
46c1e61
@RalfJung
remove outdated comment
4951d5f
@RalfJung
vec tets: ensure pointer is still writeable
a68afa2
@bors
Auto merge of rust-lang#2959 - RalfJung:vectest, r=RalfJung
89c2596 
vec tets: ensure pointer is still writeable

Under Tree Borrows, a pointer can become read-only: still allowing reads but not permitting writes any more. So these tests that want to check that pointers remain valid need to do writes to ensure that pointers indeed remain fully valid.
@bors
Auto merge of rust-lang#2957 - RalfJung:zulip, r=oli-obk
2b3fae1 
send link to PR to Zulip
@RalfJung
better error on missing #[start]
812f9b2
@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2023

The Miri subtree was changed

cc @rust-lang/miri

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@RalfJung RalfJung changed the title Miri update Miri Jul 8, 2023
@Mark-Simulacrum
Copy link
Member

r? @RalfJung

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2023

Could not assign reviewer from: RalfJung.
User(s) RalfJung are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

@RalfJung
Copy link
Member Author

RalfJung commented Jul 9, 2023

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 9, 2023

📌 Commit 9ed4669 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 9, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#113488 - RalfJung:miri, r=RalfJung
80a0bdd 
update Miri
@bors
Copy link
Contributor

bors commented Jul 9, 2023

⌛ Testing commit 9ed4669 with merge b12ff66...

@bors
Copy link
Contributor

bors commented Jul 9, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing b12ff66 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 9, 2023
@bors bors merged commit b12ff66 into rust-lang:master Jul 9, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 9, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b12ff66): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.0% [-2.8%, -1.4%] 10
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -1.6% [-2.8%, 2.6%] 11

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.544s -> 657.878s (-0.10%)

@RalfJung RalfJung deleted the miri branch July 10, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @Mark-Simulacrum @bors @rust-timer @oli-obk @icewind1991