While let suggestion will work for closure body #113567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
cjgillot
reviewed
Jul 11, 2023
chenyukang
force-pushed
the
yukang-fix-113354-while-let
branch
from
6e8d577
to
07a5a52
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-113354-while-let
branch
from
07a5a52
to
9aed969
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
This was referenced Jul 12, 2023
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 12, 2023
…-let, r=cjgillot While let suggestion will work for closure body Fixes rust-lang#113354
This was referenced Jul 12, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 12, 2023
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#113373 (various download-rustc fixes) - rust-lang#113385 (style-guide: Fix chain example to match rustfmt behavior) - rust-lang#113567 (While let suggestion will work for closure body) - rust-lang#113579 (Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy …) - rust-lang#113595 (Use constants from object crate) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 14, 2023
…dy_owned_by, r=cjgillot Use maybe_body_owned_by for multiple suggestions This is a continued work from rust-lang#113567 We have several other suggestions not working for closure, this PR use `maybe_body_owned_by` to fix them and add test cases for them.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 14, 2023
…dy_owned_by, r=cjgillot Use maybe_body_owned_by for multiple suggestions This is a continued work from rust-lang#113567 We have several other suggestions not working for closure, this PR use `maybe_body_owned_by` to fix them and add test cases for them.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jul 16, 2023
…by, r=cjgillot Use maybe_body_owned_by for multiple suggestions This is a continued work from rust-lang/rust#113567 We have several other suggestions not working for closure, this PR use `maybe_body_owned_by` to fix them and add test cases for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113354