-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy … #113579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08ce68b.
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Jul 11, 2023
Thanks for the PR! |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 11, 2023
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 12, 2023
Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy … ## why - [x] revert my broken PR rust-lang#110906 This reverts commit 08ce68b.
This was referenced Jul 12, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 12, 2023
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#113373 (various download-rustc fixes) - rust-lang#113385 (style-guide: Fix chain example to match rustfmt behavior) - rust-lang#113567 (While let suggestion will work for closure body) - rust-lang#113579 (Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy …) - rust-lang#113595 (Use constants from object crate) r? `@ghost` `@rustbot` modify labels: rollup
pld-gitsync
pushed a commit
to pld-linux/rust
that referenced
this pull request
Jul 14, 2023
- fix build by applying upstream revert, see: rust-lang/rust#113678 - roll back to original location for bash completion, from: rust-lang/rust#113579
ehuss
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
stable-nominated
Nominated for backporting to the compiler in the stable channel.
labels
Jul 14, 2023
I'm nominating for beta and stable backport. This broke bash completion for users of rustup, see rust-lang/rustup#3407. cc @rust-lang/release |
rustbot
added
beta-accepted
Accepted for backporting to the compiler in the beta channel.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
labels
Jul 28, 2023
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2023
Prepare Rust 1.71.1 This PR prepares the Rust 1.71.1 release, which contains: * rust-lang#113802 * rust-lang#113579 * rust-lang#111516 * rust-lang#112517 * rust-lang@67b5990 (from rust-lang#113678) r? `@ghost` cc `@rust-lang/release`
Merged
cuviper
removed
beta-nominated
Nominated for backporting to the compiler in the beta channel.
stable-nominated
Nominated for backporting to the compiler in the stable channel.
labels
Aug 12, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 12, 2023
[beta] backport * Restrict linker version script of proc-macro crates to just its two symbols rust-lang#114470 * bootstrap: config: fix version comparison bug rust-lang#114440 * lint/ctypes: only try normalize rust-lang#113921 * Avoid tls access while iterating through mpsc thread entries rust-lang#113861 * Substitute types before checking inlining compatibility. rust-lang#113802 * Revert "fix: bug etc/bash_complettion -> src/etc/... to avoid copy error" rust-lang#113579 * lint/ctypes: fix () return type checks rust-lang#113457 * Rename and allow cast_ref_to_mut lint rust-lang#113422 * Ignore flaky clippy tests. rust-lang#113621 r? cuviper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
reverts #110906
This reverts commit 08ce68b.