-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DestinationPropagation by default. #115105
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 3a7cd3992c305fc85f47c3f8b1529a190578558f with merge bc959a66e49afdd420b5983051c6fe0004b08764... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (bc959a66e49afdd420b5983051c6fe0004b08764): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 634.51s -> 634.058s (-0.07%) |
3a7cd39
to
388804d
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 388804de0e1798da7828759ac2f0c52164e7f2b1 with merge 249071430ed663b2a6c13c118a88c73c03c35050... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (249071430ed663b2a6c13c118a88c73c03c35050): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 630.77s -> 632.971s (0.35%) |
388804d
to
4fc796b
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 4fc796bfabd8481ec2b89224030e92f3b7346494 with merge e8ecd4bd0b0f35deb36c1d1baee03c268646c4f1... |
aa05ea6
to
70d3cae
Compare
☔ The latest upstream changes (presumably #121370) made this pull request unmergeable. Please resolve the merge conflicts. |
r? mir-opt |
70d3cae
to
aca6562
Compare
aca6562
to
63555ae
Compare
☔ The latest upstream changes (presumably #124914) made this pull request unmergeable. Please resolve the merge conflicts. |
logic wise this is fine. Performance wise it's not ideal, but at least we have a FIXMEs to work on and a better pass to edit. r=me after another rebase |
63555ae
to
5fa0ec6
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cfb7304): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 1.2%, secondary 2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.3%, secondary 4.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.1%, secondary 0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 666.558s -> 669.847s (0.49%) |
@cjgillot I believe this PR has caused the Discussion at https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/x86_64-gnu-llvm-17.20job.20being.20really.20slow |
Posted #125794 |
…rrors Revert "Auto merge of rust-lang#115105 - cjgillot:dest-prop-default, r=oli-obk" This reverts commit cfb7304, reversing changes made to 91c0823. To address rust-lang#115105 (comment) r? `@oli-obk` <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> -->
@rustbot label: +perf-regression-triaged |
Based on #115291.This PR proposes to enable the destination propagation pass by default.
This pass is meant to reduce the amount of copies present in MIR.
At the same time, this PR removes the
RenameReturnPlace
pass, as it is currently unsound.DestinationPropagation
is not limited to_0
, but does not handle borrowed locals.