Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Auto merge of #115105 - cjgillot:dest-prop-default, r=oli-obk" #125794

Merged
merged 1 commit into from
May 31, 2024

Conversation

cjgillot
Copy link
Contributor

This reverts commit cfb7304, reversing changes made to 91c0823.

To address #115105 (comment)
r? @oli-obk

…r=oli-obk"

This reverts commit cfb7304, reversing
changes made to 91c0823.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 31, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup=never p=10

@bors
Copy link
Contributor

bors commented May 31, 2024

📌 Commit e110567 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2024
@bors
Copy link
Contributor

bors commented May 31, 2024

⌛ Testing commit e110567 with merge 366da30...

@bors
Copy link
Contributor

bors commented May 31, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 366da30 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 31, 2024
@bors bors merged commit 366da30 into rust-lang:master May 31, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 31, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (366da30): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.2%, 4.2%] 18
Regressions ❌
(secondary)
0.8% [0.1%, 1.5%] 20
Improvements ✅
(primary)
-1.0% [-3.2%, -0.3%] 15
Improvements ✅
(secondary)
-1.5% [-3.1%, -0.4%] 18
All ❌✅ (primary) -0.2% [-3.2%, 4.2%] 33

Max RSS (memory usage)

Results (primary -0.7%, secondary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [2.2%, 7.5%] 5
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.1% [-7.9%, -0.7%] 6
Improvements ✅
(secondary)
-4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) -0.7% [-7.9%, 7.5%] 11

Cycles

Results (primary -1.0%, secondary -3.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-1.6% [-2.0%, -1.1%] 7
Improvements ✅
(secondary)
-4.6% [-5.7%, -2.2%] 6
All ❌✅ (primary) -1.0% [-2.0%, 3.2%] 8

Binary size

Results (primary 0.1%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 0.7%] 51
Regressions ❌
(secondary)
0.9% [0.1%, 1.5%] 13
Improvements ✅
(primary)
-0.1% [-0.6%, -0.0%] 29
Improvements ✅
(secondary)
-0.4% [-6.1%, -0.0%] 54
All ❌✅ (primary) 0.1% [-0.6%, 0.7%] 80

Bootstrap: 672.444s -> 666.738s (-0.85%)
Artifact size: 318.74 MiB -> 318.79 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label May 31, 2024
@pnkfelix
Copy link
Member

pnkfelix commented Jun 4, 2024

  • revert of PR which had big performance regression not caught by benchmark suite
  • marking as triaged

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 4, 2024
@cjgillot cjgillot deleted the revert-115105 branch June 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants