Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative positions inside a SourceFile. #115507

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Use relative positions inside a SourceFile. #115507

merged 7 commits into from
Sep 5, 2023

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Sep 3, 2023

This allows to remove the normalization of start positions for hashing, and simplify allocation of global address space.

cc @Zoxc

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 3, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 3, 2023
@bors
Copy link
Contributor

bors commented Sep 3, 2023

⌛ Trying commit 9755022997cd6860c94773ae023743160ddb7235 with merge 95fa9e122172b6f0825c4cc4d7d8d46892bed79f...

@bors
Copy link
Contributor

bors commented Sep 3, 2023

☀️ Try build successful - checks-actions
Build commit: 95fa9e122172b6f0825c4cc4d7d8d46892bed79f (95fa9e122172b6f0825c4cc4d7d8d46892bed79f)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (95fa9e122172b6f0825c4cc4d7d8d46892bed79f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 631.425s -> 628.246s (-0.50%)
Artifact size: 316.57 MiB -> 316.61 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 3, 2023
Zoxc
Zoxc reviewed Sep 3, 2023
View reviewed changes
compiler/rustc_span/src/lib.rs Outdated Show resolved Hide resolved
Zoxc
Zoxc reviewed Sep 3, 2023
View reviewed changes
compiler/rustc_span/src/lib.rs Outdated Show resolved Hide resolved
Zoxc
Zoxc reviewed Sep 3, 2023
View reviewed changes
compiler/rustc_span/src/lib.rs Outdated Show resolved Hide resolved
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 5, 2023

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 5, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2023

📌 Commit 3edeac0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2023
@cjgillot cjgillot mentioned this pull request Sep 5, 2023
Closed
@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Testing commit 3edeac0 with merge e2603e46b87c285d317802bf8759642b048cdc3f...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Sep 5, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2023
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 5, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023
@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Testing commit 3edeac0 with merge a991861...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a991861 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2023
@bors bors merged commit a991861 into rust-lang:master Sep 5, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 5, 2023
@bors bors mentioned this pull request Sep 5, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a991861): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 8
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 3
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 8

Bootstrap: 627.53s -> 628.337s (0.13%)
Artifact size: 316.30 MiB -> 316.11 MiB (-0.06%)

@cjgillot cjgillot deleted the relative-source-file branch September 6, 2023 06:23
@xFrednet xFrednet mentioned this pull request Sep 6, 2023
Closed
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 7, 2023
@bors
Auto merge of rust-lang#115507 - cjgillot:relative-source-file, r=oli…
953901e 
…-obk

Use relative positions inside a SourceFile.

This allows to remove the normalization of start positions for hashing, and simplify allocation of global address space.

cc `@Zoxc`
@Zalathar Zalathar mentioned this pull request Nov 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoxc Zoxc Zoxc left review comments

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rustbot @rust-log-analyzer @rust-timer @bors @oli-obk @Zoxc