Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insert duplicate SourceFile. #115572

Closed

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Sep 5, 2023

Based on #115507
Addresses #115507 (comment)

cc @Zoxc
r? @oli-obk

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2023

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-15 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=cjgillot
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_78d6141d-a424-4ffc-95f3-bd5a30c4e9c4
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=de6efa3a65bc77b16bbb07c4e08e6213e1e3a059
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_78d6141d-a424-4ffc-95f3-bd5a30c4e9c4
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_78d6141d-a424-4ffc-95f3-bd5a30c4e9c4
GITHUB_TRIGGERING_ACTOR=cjgillot
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/115572/merge
GITHUB_WORKFLOW_SHA=de6efa3a65bc77b16bbb07c4e08e6213e1e3a059
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_18_X64=/opt/hostedtoolcache/go/1.18.10/x64
---
..............................F....

failures:

---- source_map::tests::t10 stdout ----
thread 'source_map::tests::t10' panicked at compiler/rustc_span/src/source_map/tests.rs:262:62:
error: test failed, to rerun pass `-p rustc_span --lib`
called `Option::unwrap()` on a `None` value


failures:
    source_map::tests::t10

@Zoxc
Copy link
Contributor

Zoxc commented Sep 7, 2023

The last commit looks good to me.

@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2023
@bors
Copy link
Contributor

bors commented Nov 3, 2023

☔ The latest upstream changes (presumably #117507) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

@cjgillot ping from triage - can you post your status on this PR? This PR has not received an update in a few months.

@oskgo
Copy link
Contributor

oskgo commented Aug 18, 2024

@cjgillot

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this.
Note: if you are going to continue please open the PR BEFORE you push to it, else you won't be able to reopen - this is a quirk of github.
Thanks for your contribution.

@rustbot label: +S-inactive

@oskgo oskgo closed this Aug 18, 2024
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants