Don't ICE when computing ctype's repr_nullable_ptr for possibly-unsized ty
#115631
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler-errors
changed the title
repr_nullable_ptr for possibly-unsized ty
rustbot
added
S-waiting-on-review
davidtwco
approved these changes
Sep 11, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115548 (Extract parallel operations in `rustc_data_structures::sync` into a new `parallel` submodule) - rust-lang#115591 (Add regression test for LLVM 17-rc3 miscompile) - rust-lang#115631 (Don't ICE when computing ctype's `repr_nullable_ptr` for possibly-unsized ty) - rust-lang#115708 (fix homogeneous_aggregate not ignoring some ZST) - rust-lang#115730 (Some more small driver refactors) - rust-lang#115749 (Allow loading the SMIR for constants and statics) - rust-lang#115757 (Add a test for rust-lang#108030) - rust-lang#115761 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
Rollup merge of rust-lang#115631 - compiler-errors:ctypes-unsized, r=davidtwco Don't ICE when computing ctype's `repr_nullable_ptr` for possibly-unsized ty We may not always be able to compute the layout of a type like `&T` when `T: ?Sized`, even if we're able to estimate its size skeleton. r? davidtwco Fixes rust-lang#115628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may not always be able to compute the layout of a type like
&TwhenT: ?Sized, even if we're able to estimate its size skeleton.r? davidtwco
Fixes #115628