-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more small driver refactors #115730
Merged
Merged
Some more small driver refactors #115730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid confusion if it is called after all parsing is done or not.
Only deprecating it rather than making it private to just in case someone has a use case for it.
It is only used by miri which can create a new one using the Session.
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Sep 10, 2023
The Miri subtree was changed cc @rust-lang/miri This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino |
r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 10, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115548 (Extract parallel operations in `rustc_data_structures::sync` into a new `parallel` submodule) - rust-lang#115591 (Add regression test for LLVM 17-rc3 miscompile) - rust-lang#115631 (Don't ICE when computing ctype's `repr_nullable_ptr` for possibly-unsized ty) - rust-lang#115708 (fix homogeneous_aggregate not ignoring some ZST) - rust-lang#115730 (Some more small driver refactors) - rust-lang#115749 (Allow loading the SMIR for constants and statics) - rust-lang#115757 (Add a test for rust-lang#108030) - rust-lang#115761 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
Rollup merge of rust-lang#115730 - bjorn3:some_driver_refactors, r=compiler-errors Some more small driver refactors To improve clarity and simplify some code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve clarity and simplify some code.