Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix r-a rustfmt command #115818

Closed
wants to merge 2 commits into from
Closed

fix r-a rustfmt command #115818

wants to merge 2 commits into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Sep 13, 2023

Recent versions of rust-analyzer trigger errors when formatting a file. The log looks like

[Error - 2:36:48 PM] Request textDocument/formatting failed.
  Message: Failed to spawn cd "/home/lqd/rust/compiler/rustc_trait_selection/src/traits/select" && "./build/host/rustfmt/bin/rustfmt" "--edition=2021"
  Code: -32603

This PR switches the relative path in the r-a settings to a workspace path, so that calling rustfmt works from any folder and not just the workspace root.

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2023
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 13, 2023
@lqd lqd mentioned this pull request Sep 14, 2023
Merged
@RalfJung
Copy link
Member

I accidentally opened almost-but-not-quite the same PR at #115836.

@bors
Copy link
Contributor

bors commented Sep 17, 2023

☔ The latest upstream changes (presumably #115900) made this pull request unmergeable. Please resolve the merge conflicts.

@lqd lqd closed this Sep 17, 2023
@lqd lqd deleted the fix-ra-rustfmt branch September 17, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lqd @rustbot @rust-log-analyzer @RalfJung @bors @Mark-Simulacrum