Rollup of 8 pull requests #115900

matthiaskrgr · 2023-09-16T21:20:43Z

Successful merges:

Document std limitations before/after main #115247 (Document std limitations before/after main)
fix std::primitive doc: homogenous -> homogeneous #115329 (fix std::primitive doc: homogenous -> homogeneous)
Improve documentation on when signes are printed by default #115487 (Improve documentation on when signes are printed by default)
Update doc for alloc::format! and core::concat! #115560 (Update doc for alloc::format! and core::concat!)
update rust_analyzer_settings.json #115836 (update rust_analyzer_settings.json)
make ty::Const debug printing less verbose #115884 (make ty::Const debug printing less verbose)
Migrate GUI colors test to original CSS color format #115890 (Migrate GUI colors test to original CSS color format)
Improve Vec(Deque)::truncate documentation #115895 (Improve Vec(Deque)::truncate documentation)

r? @ghost
@rustbot modify labels: rollup

Document std limitations before/after main Solves rust-lang#110708

fix std::primitive doc: homogenous -> homogeneous replace "homogenous" with the more commonly used "homogeneous".

Improve documentation on when signes are printed by default I found the original formulation a bit irritating, but not sure if I really improved it.

Update doc for `alloc::format!` and `core::concat!` Closes rust-lang#115551. Used comments instead of `assert!`s as [`std::fmt`](https://doc.rust-lang.org/std/fmt/index.html#usage) uses comments. Should all the str-related macros (`format!`, `format_args!`, `concat!`, `stringify!`, `println!`, `writeln!`, etc.) references each others? For instance, [`concat!`](https://doc.rust-lang.org/core/macro.concat.html) mentions that integers are stringified, but don't link to `stringify!`. `@rustbot` label +A-docs +A-fmt

…on, r=compiler-errors update rust_analyzer_settings.json This works around rust-lang/rust-analyzer#15595, and avoids relying on the unspecified working directory of this command.

make ty::Const debug printing less verbose Similar in spirit to rust-lang#115873

…lor-41, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`

Improve Vec(Deque)::truncate documentation Fixes rust-lang#115784

matthiaskrgr · 2023-09-16T21:20:58Z

@bors r+ rollup=never p=8

bors · 2023-09-16T21:20:59Z

📌 Commit e2ea347 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-09-16T22:09:05Z

⌛ Testing commit e2ea347 with merge 7d9bce3...

bors · 2023-09-16T23:57:41Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7d9bce3 to master...

rust-timer · 2023-09-16T23:59:55Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#115247	Document std limitations before/after main	`63bd8ded04158162fa182acbd4d622f32919e2a6` (link)
#115329	fix std::primitive doc: homogenous -> homogeneous	`7c47415273a155ed9ebfba017dd6373806a467c4` (link)
#115487	Improve documentation on when signes are printed by default	`8157eada429df7e7692dd81e29a2c92343fe7d2c` (link)
#115560	Update doc for `alloc::format!` and `core::concat!`	`023f1103ec056c8f57e0db34390e775ecbffab2f` (link)
#115836	update rust_analyzer_settings.json	`e0b5514b303372d8e613491d0568f1725e538484` (link)
#115884	make ty::Const debug printing less verbose	`e07e8b173348ec7ce7f68d451e16b03a6b58ca72` (link)
#115890	Migrate GUI colors test to original CSS color format	`0b9529801220a3f9472cf4ce6a0d1d95154d6671` (link)
#115895	Improve Vec(Deque)::truncate documentation	`d2ace2eafd3566ec6f1bb3fb1abbbc574a5fad69` (link)

previous master: 341ef15eee

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-09-17T01:46:49Z

Finished benchmarking commit (7d9bce3): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.2%, 0.6%]	4
Improvements ✅ (primary)	-1.1%	[-1.5%, -0.7%]	7
Improvements ✅ (secondary)	-0.8%	[-1.2%, -0.4%]	6
All ❌✅ (primary)	-1.1%	[-1.5%, -0.7%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.0%, 1.8%]	2
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-1.8%, 1.8%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-5.1%, -1.0%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-5.1%, -1.0%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.945s -> 636.475s (0.56%)
Artifact size: 318.26 MiB -> 318.37 MiB (0.03%)

Mark-Simulacrum · 2023-09-19T13:50:29Z

It looks like most or all of these are within what I would call noise floor (sporadic, but still looks to be noise):

the8472 and others added 19 commits August 26, 2023 15:42

Document std limitations before/after main

b96db22

fix a doc typo at std::os::unix::fs::FileExt::write_at

3431fb7

fix std::primitive doc: homogenous -> homogeneous

57fccf9

Improve documentation on when signes are printed by default

f479538

Update doc for alloc::format! and core::concat!

94e651b

update rust_analyzer_settings.json

6dbcf5f

update SETTINGS_HASHES

9af39a6

Migrate GUI colors test to original CSS color format

e691752

edit std::vec::Vec::truncate docs

d1ff5e1

edit std::collections::VecDeque docs

1c7a77a

make ty::Const debug printing less verbose

5a3410a

Rollup merge of rust-lang#115247 - the8472:life-before-main, r=dtolnay

cf9ce96

Document std limitations before/after main Solves rust-lang#110708

Rollup merge of rust-lang#115329 - xzmeng:fix-std-doc, r=dtolnay

edfe8b4

fix std::primitive doc: homogenous -> homogeneous replace "homogenous" with the more commonly used "homogeneous".

Rollup merge of rust-lang#115487 - ModProg:patch-1, r=dtolnay

b8c4b78

Improve documentation on when signes are printed by default I found the original formulation a bit irritating, but not sure if I really improved it.

Rollup merge of rust-lang#115836 - RalfJung:rust_analyzer_settings.js…

edea0d5

…on, r=compiler-errors update rust_analyzer_settings.json This works around rust-lang/rust-analyzer#15595, and avoids relying on the unspecified working directory of this command.

Rollup merge of rust-lang#115884 - RalfJung:const-debug-print, r=oli-obk

abae2b6

make ty::Const debug printing less verbose Similar in spirit to rust-lang#115873

Rollup merge of rust-lang#115890 - GuillaumeGomez:migrate-gui-test-co…

5a8179b

…lor-41, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? `@notriddle`

Rollup merge of rust-lang#115895 - 52:patch-docs-vec-truncate, r=dtolnay

e2ea347

Improve Vec(Deque)::truncate documentation Fixes rust-lang#115784

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2023

bors merged commit 7d9bce3 into rust-lang:master Sep 16, 2023
12 checks passed

rustbot added this to the 1.74.0 milestone Sep 16, 2023

bors mentioned this pull request Sep 17, 2023

fix r-a rustfmt command #115818

Closed

rustbot added the perf-regression Performance regression. label Sep 17, 2023

Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Sep 19, 2023

matthiaskrgr deleted the rollup-3ba15da branch March 16, 2024 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #115900

Rollup of 8 pull requests #115900

matthiaskrgr commented Sep 16, 2023

matthiaskrgr commented Sep 16, 2023

bors commented Sep 16, 2023

bors commented Sep 16, 2023

bors commented Sep 16, 2023

rust-timer commented Sep 16, 2023

rust-timer commented Sep 17, 2023

Mark-Simulacrum commented Sep 19, 2023

Rollup of 8 pull requests #115900

Rollup of 8 pull requests #115900

Conversation

matthiaskrgr commented Sep 16, 2023

matthiaskrgr commented Sep 16, 2023

bors commented Sep 16, 2023

bors commented Sep 16, 2023

bors commented Sep 16, 2023

rust-timer commented Sep 16, 2023

rust-timer commented Sep 17, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Mark-Simulacrum commented Sep 19, 2023