-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture scrutinee of if let guards correctly #115999
Merged
bors
merged 1 commit into
rust-lang:master
from
matthewjasper:closure-capture-let-guards
Sep 22, 2023
Merged
Capture scrutinee of if let guards correctly #115999
bors
merged 1 commit into
rust-lang:master
from
matthewjasper:closure-capture-let-guards
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Sep 20, 2023
b-naber
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with nit addressed.
Previously we were always capturing by value.
matthewjasper
force-pushed
the
closure-capture-let-guards
branch
from
September 22, 2023 13:05
52711ba
to
d4ffb3b
Compare
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 22, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115770 (Match on elem first while building move paths) - rust-lang#115999 (Capture scrutinee of if let guards correctly) - rust-lang#116056 (Make unsized casts illegal) - rust-lang#116061 (Remove TaKO8Ki from review rotation) - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis) - rust-lang#116067 (Open the FileEncoder file for reading and writing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
Rollup merge of rust-lang#115999 - matthewjasper:closure-capture-let-guards, r=b-naber Capture scrutinee of if let guards correctly Previously we were always capturing by value. cc rust-lang#51114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F-if_let_guard
`#![feature(if_let_guard)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were always capturing by value.
cc #51114