Skip to content

Conversation

matthewjasper
Copy link
Contributor

Previously we were always capturing by value.

cc #51114

@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2023
Copy link
Contributor

@b-naber b-naber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit addressed.

Previously we were always capturing by value.
@matthewjasper matthewjasper force-pushed the closure-capture-let-guards branch from 52711ba to d4ffb3b Compare September 22, 2023 13:05
@b-naber
Copy link
Contributor

b-naber commented Sep 22, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 22, 2023

📌 Commit d4ffb3b has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#115770 (Match on elem first while building move paths)
 - rust-lang#115999 (Capture scrutinee of if let guards correctly)
 - rust-lang#116056 (Make unsized casts illegal)
 - rust-lang#116061 (Remove TaKO8Ki from review rotation)
 - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis)
 - rust-lang#116067 (Open the FileEncoder file for reading and writing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e6f4b35 into rust-lang:master Sep 22, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 22, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
Rollup merge of rust-lang#115999 - matthewjasper:closure-capture-let-guards, r=b-naber

Capture scrutinee of if let guards correctly

Previously we were always capturing by value.

cc rust-lang#51114
@matthewjasper matthewjasper deleted the closure-capture-let-guards branch September 22, 2023 23:40
@matthewjasper matthewjasper added the F-if_let_guard `#![feature(if_let_guard)]` label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-if_let_guard `#![feature(if_let_guard)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants