-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TaKO8Ki from review rotation #116061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 22, 2023
I've been busy with other matters recently, so I'll be back in a while. |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 22, 2023
Thanks @TaKO8Ki for helping with reviews! It is very much appreciated 🏅 Feel free to revert this whenever you are ready to review again 🙂 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115770 (Match on elem first while building move paths) - rust-lang#115999 (Capture scrutinee of if let guards correctly) - rust-lang#116056 (Make unsized casts illegal) - rust-lang#116061 (Remove TaKO8Ki from review rotation) - rust-lang#116062 (Change `start` to `#[start]` in some diagnosis) - rust-lang#116067 (Open the FileEncoder file for reading and writing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
Rollup merge of rust-lang#116061 - Nilstrieb:Nilstrieb-patch-1, r=TaKO8Ki Remove TaKO8Ki from review rotation `@TaKO8Ki` you haven't been actively reviewing pull requests lately, so I'm removing you from the rotation. Thank you for all the PRs you have reviewed when you were more actively, it was very helpful! Feel free to add yourself back when you have more time 💜 r? `@wesleywiser` `@davidtwco`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2023
…eviewers, r=Nilstrieb Revert "Remove TaKO8Ki from reviewers" ref rust-lang#116061 It's been a month since this pull request, and I now have some available time for reviews. Would it be okay to revisit it as a reviewer? This reverts commit 8e06b25. r? `@Nilstrieb`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 26, 2023
…-reviewers, r=Nilstrieb Revert "Remove TaKO8Ki from reviewers" ref rust-lang#116061 It's been a month since this pull request, and I now have some available time for reviews. Would it be okay to revisit it as a reviewer? This reverts commit 8e06b25. r? `@Nilstrieb`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2023
Rollup merge of rust-lang#117202 - TaKO8Ki:revert-remove-TaKO8Ki-from-reviewers, r=Nilstrieb Revert "Remove TaKO8Ki from reviewers" ref rust-lang#116061 It's been a month since this pull request, and I now have some available time for reviews. Would it be okay to revisit it as a reviewer? This reverts commit 8e06b25. r? `@Nilstrieb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TaKO8Ki you haven't been actively reviewing pull requests lately, so I'm removing you from the rotation. Thank you for all the PRs you have reviewed when you were more actively, it was very helpful! Feel free to add yourself back when you have more time 💜
r? @wesleywiser @davidtwco