Add Span to various smir types

[ouz-a]

Had to make few extra changes to few structs to attach spans to them.

r? @oli-obk

[rustbot]

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

[spastorino]

I'd do let span = self.source_info.span.stable(tables); at the top and then just do span, here.

[spastorino]

Same here, move the span assignment outside the match.

[spastorino]

This looks good to me, modulo my tiny nit.

[ouz-a]

This looks good to me, modulo my tiny nit.

well code looks way cleaner now, thanks!

[spastorino]

Another thing that I was thinking that didn't realize yesterday, why don't we implement stable for kind?. Then I think you won't even need this span binding and code would likely be even cleaner.

[ouz-a]

Another thing that I was thinking that didn't realize yesterday, why don't we implement stable for kind?. Then I think you won't even need this span binding and code would likely be even cleaner.

That could also work, and indeed it will make the code cleaner but I think this will print out nicer Spans, and will make accessing spans easier, for parsing stuff in the future(if we do something like that).

[spastorino]

@ouz-a unsure if you've followed what I've said or if I'm missing something :). What I meant to say is equivalent (unless I'm missing something), you can just go for instance from mir::StatementKind to stable_mir::mir::StatementKind and those don't hold any span.

You would end with code like ...

Statement {
    kind: self.kind.stable(tables),
    span: self.source_info.span.stable(tables),
}

And adding the StatementKind thing.

[ouz-a]

@ouz-a unsure if you've followed what I've said or if I'm missing something :). What I meant to say is equivalent (unless I'm missing something), you can just go for instance from mir::StatementKind to stable_mir::mir::StatementKind and those don't hold any span.

You would end with code like ...

Statement {
    kind: self.kind.stable(tables),
    span: self.source_info.span.stable(tables),
}

And adding the StatementKind thing.

Oh I misread your message, I read that as implementing Span for Kinds, (it was late here when I read it 🤣 ) yeah your suggestion is right, I added it on last commit.

[spastorino]

@bors r+ rollup

[bors]

📌 Commit a49138e has been approved by spastorino

It is now in the queue for this repository.