Remove libc

[ChrisDenton]

We don't use much libc on Windows and it seemed silly to keep if for the sake of two well documented constants.

[rustbot]

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

[workingjubilee]

Is it possible to make this an actual removal in the Cargo.toml with enough cfg?

[ChrisDenton]

I would love to. But currently we use it for linking the CRT. Tbh I'm not sure why this is hard coded in the libc crate rather than being something the compiler does (like it is with -gnu) but I'd really love to change that. At the very least so that it can be overridden more easily (e.g. with the debug CRT).

[workingjubilee]

Can you open an issue for that?

[ChrisDenton]

I was about to but then realised I kinda of already had: #107570.

[workingjubilee]

Oh, neat!

[workingjubilee]

@bors r+

[bors]

📌 Commit c8f3aa4 has been approved by workingjubilee

It is now in the queue for this repository.

[bors]

⌛ Testing commit c8f3aa4 with merge fd80c02...

[bors]

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing fd80c02 to master...

[rust-timer]

Finished benchmarking commit (fd80c02): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-3.8%, -1.5%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 623.044s -> 624.133s (0.17%)
Artifact size: 270.64 MiB -> 270.63 MiB (-0.00%)