-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo of moving std::io::Error to core #116685
Conversation
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
657453d
to
4689d00
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
I think it's because the incoherent impl is added in two |
4689d00
to
a2430ef
Compare
This comment has been minimized.
This comment has been minimized.
a2430ef
to
f896b0f
Compare
This comment has been minimized.
This comment has been minimized.
f896b0f
to
f0466ad
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
looks good to me |
☔ The latest upstream changes (presumably #117736) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm clearing this from my queue while it's in draft, but you can use @rustbot author |
@programmerjake any updates on this? thanks |
as stated on the top comment:
my lack of time hasn't changed. |
Thanks for the update. I'm going close this since it will remain inactive and bitrot (already has). When you have the time you can reöpen or preferably create a new pr and link to this one. |
I mostly wanted to show my idea for how to move
std::io::Error
tocore
. I useAtomicPtr
to fill in the parts that are needed fromalloc
/std
, but that should probably be replaced with something like#[panic_handler]
or#[global_allocator]
except where it resolves to a null pointer instead of erroring if not provided.I am not very likely to finish this off due to lack of time, so, anyone who wants to, feel free to base your code on mine.