Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in CI for aarch64-apple-darwin #117454

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Run tests in CI for aarch64-apple-darwin #117454

merged 3 commits into from
Nov 9, 2023

Conversation

shepmaster
Copy link
Member

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 31, 2023
@shepmaster
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Trying commit bf07b27 with merge 7655317...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023
@bors
Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …
7655317 
…r=<try>

Run tests in CI for aarch64-apple-darwin

r? `@ghost`
@bors
Copy link
Contributor

bors commented Oct 31, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@shepmaster
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Trying commit 7a2ab46 with merge 223ccde...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023
@bors
Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …
223ccde 
…r=<try>

Run tests in CI for aarch64-apple-darwin

r? `@ghost`
@bors
Copy link
Contributor

bors commented Oct 31, 2023

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@shepmaster
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Trying commit 83d2dd2 with merge 2e94d63...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023
@bors
Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …
2e94d63 
…r=<try>

Run tests in CI for aarch64-apple-darwin

r? `@ghost`
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Oct 31, 2023

💔 Test failed - checks-actions

@shepmaster
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Trying commit 4e9c7b8 with merge d98697a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023
@bors
Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …
d98697a 
…r=<try>

Run tests in CI for aarch64-apple-darwin

r? `@ghost`
@bors
Copy link
Contributor

bors commented Oct 31, 2023

☀️ Try build successful - checks-actions
Build commit: d98697a (d98697a931dea7a491f76a93555f95dad27cb356)

@shepmaster
Copy link
Member Author

This should be ready to go now!

r? @Mark-Simulacrum

@shepmaster
Copy link
Member Author

/cc @GuillaumeGomez as I'm touching the test you originally added.

@GuillaumeGomez
Copy link
Member

/cc @GuillaumeGomez as I'm touching the test you originally added.

Thanks, much appreciated! :)

@shepmaster shepmaster marked this pull request as ready for review November 8, 2023 13:46
@shepmaster
Mark Rustdoc test as Linux-only
469d34b 
Due to incorrect CI configuration, this test was not being run on
macOS. aarch64-apple-darwin will start running it, so we correct the
configuration.
@shepmaster
Install tidy for aarch64-apple-darwin
6409053 
The GitHub Actions image has this preinstalled for x86_64 but not M1.
@shepmaster
Run tests in CI for aarch64-apple-darwin
6909992
GuillaumeGomez
GuillaumeGomez approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustdoc test changes look good to me!

@GuillaumeGomez
Copy link
Member

Let's set a reviewer from the infra team now.

r? @onur-ozkan

@rustbot rustbot assigned onur-ozkan and unassigned Mark-Simulacrum Nov 8, 2023
onur-ozkan
onur-ozkan approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me other than 1 question

src/ci/scripts/install-tidy.sh Show resolved Hide resolved
@onur-ozkan
Copy link
Member

I don't know when you want to ship this so I leave it to you. Feel free to r=GuillaumeGomez,me.

@shepmaster
Copy link
Member Author

@bors r=GuillaumeGomez,onur-ozkan

@bors
Copy link
Contributor

bors commented Nov 8, 2023

📌 Commit 6909992 has been approved by GuillaumeGomez,onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2023
@bors
Copy link
Contributor

bors commented Nov 8, 2023

⌛ Testing commit 6909992 with merge 57fb1e6...

@bors
Copy link
Contributor

bors commented Nov 9, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez,onur-ozkan
Pushing 57fb1e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2023
@bors bors merged commit 57fb1e6 into rust-lang:master Nov 9, 2023
12 checks passed
@rustbot rustbot added this to the 1.75.0 milestone Nov 9, 2023
@shepmaster shepmaster deleted the github-actions-m1-tests branch November 9, 2023 01:55
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (57fb1e6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

  • exa-0.10.1
  • diesel-1.4.8

cc @rust-lang/wg-compiler-performance

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.4%, 1.2%] 7
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.8%, -0.4%] 2
Improvements ✅
(secondary)		 -3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) 0.4% [-0.8%, 1.2%] 9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 663.159s -> 662.945s (-0.03%)
Artifact size: 308.75 MiB -> 308.63 MiB (-0.04%)

@lqd
Copy link
Member

lqd commented Nov 9, 2023

The timeouts are most likely related to the perf collector, not this PR.

celinval added a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
@github-actions @celinval
Automatic toolchain upgrade to nightly-2023-11-10 (rust-lang#2869)
0946ca5 
Update Rust toolchain from nightly-2023-11-09 to nightly-2023-11-10
without any other source changes.
This is an automatically generated pull request. If any of the CI checks
fail, manual intervention is required. In such a case, review the
changes at https://github.com/rust-lang/rust from
rust-lang@fdaaaf9
up to
rust-lang@0f44eb3.
The log for this commit range is:
rust-lang@0f44eb32f1 Auto merge of
rust-lang#117727 - saethlin:inline-derived-fmt, r=nnethercote
rust-lang@eae4135939 Auto merge of
rust-lang#117708 - onur-ozkan:x-setup, r=clubby789
rust-lang@4c8862b263 Auto merge of
rust-lang#117122 - ferrocene:pa-configure-git-diff, r=albertlarsan68
rust-lang@d32d9238cf Emit #[inline] on
derive(Debug)
rust-lang@b7583d38b7 Auto merge of
rust-lang#117712 - lcnr:expand-coroutine, r=jackh726
rust-lang@488dd9bc73 fmt
rust-lang@e7998aa21f Auto merge of
rust-lang#117734 - nnethercote:rm-Zstrip, r=davidtwco
rust-lang@287ae4db75 Auto merge of
rust-lang#117632 - Nilstrieb:icup, r=davidtwco
rust-lang@492e57c6ad Auto merge of
rust-lang#117736 - TaKO8Ki:rollup-fjrtmlb, r=TaKO8Ki
rust-lang@d1e26401bc chore(bootstrap):
capitalize {error, warning, info, note} tags
rust-lang@42fbf3ebf5 allow users to
override the existing configuration during x setup
rust-lang@3d6417fc7a check config file
before prompts on x setup
rust-lang@f5195c52bb Rollup merge of
rust-lang#117724 - Kobzol:shim-error-message, r=onur-ozkan
rust-lang@e603f4491c Rollup merge of
rust-lang#117723 - onur-ozkan:keep-bootstrap-on-x-clean, r=albertlarsan68
rust-lang@6533c62ce7 Rollup merge of
rust-lang#117705 - tshepang:patch-2, r=Nilstrieb
rust-lang@b4fa5b7004 Rollup merge of
rust-lang#117694 - jmillikin:core-io-borrowed-buf, r=m-ou-se
rust-lang@4cc549811f Rollup merge of
rust-lang#117645 - compiler-errors:auto-trait-subst, r=petrochenkov
rust-lang@a1a8d6fe9c Rollup merge of
rust-lang#116762 - WaffleLapkin:fixup_fromptr_docs, r=RalfJung
rust-lang@d8dbf7ca0e Auto merge of
rust-lang#117557 - Zoxc:panic-prio, r=petrochenkov
rust-lang@ecc936b155 Remove `-Z strip`.
rust-lang@57fb1e643a Auto merge of
rust-lang#117454 - shepmaster:github-actions-m1-tests,
r=GuillaumeGomez,onur-ozkan
rust-lang@341c85648c Move `BorrowedBuf`
and `BorrowedCursor` from `std:io` to `core::io`
rust-lang@92267c9794 update mir-opt tests
rust-lang@992d93f687 rename
`BorrowKind::Shallow` to `Fake`
rust-lang@a42eca42df generator layout:
ignore fake borrows
rust-lang@622be2d138 Restore rustc shim
error message
rust-lang@de0458af97 speed up `x clean`
rust-lang@6909992501 Run tests in CI for
aarch64-apple-darwin
rust-lang@64090536d4 Install tidy for
aarch64-apple-darwin
rust-lang@469d34b39b Mark Rustdoc test as
Linux-only
rust-lang@bf360d407e instrument
constituent types computation
rust-lang@03435e6fdd accept review
suggestion
rust-lang@769ad29c3e triagebot.toml: use
inclusive language
rust-lang@102384523a Document how rust
atomics work wrt mixed-sized and non-atomic accesses
rust-lang@c17d33f1df Extend builtin/auto
trait args with error when they have >1 argument
rust-lang@580fa0c1a9 rename
github_repository to git_repository
rust-lang@ffffc2038f Update ICU4X
rust-lang@ff1858e2aa Make
`FatalErrorMarker` lower priority than other panics
rust-lang@4a0873533f update suggest-tests
rust-lang@5a562d962e pass the correct
args to compiletest
rust-lang@545cc830e1 allow configuring
the parent GitHub repository

Co-authored-by: celinval <celinval@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
9 participants
@shepmaster @bors @rust-log-analyzer @GuillaumeGomez @onur-ozkan @rust-timer @lqd @Mark-Simulacrum @rustbot