-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backtrace submodule #118137
Update backtrace submodule #118137
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
|
I've nominated this for a beta backport as otherwise we'd be breaking Windows 7 on the next stable release. We should avoid doing that until 1.76 at the earliest. |
@bors r=ChrisDenton |
☀️ Test successful - checks-actions |
Finished benchmarking commit (2f8d81f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 676.058s -> 679.348s (0.49%) |
Heyo, is there a way to track the backporting process? It kinda looks like it fell through the cracks (all previously beta-nominated PRs have been accepted/rejected), and I'd be interested in seeing if there's any question I can help with. (Also, I think this is missing a team label? I assume |
Beta-accepted as per libs team meeting. |
[beta] Update backtrace submodule * Update backtrace submodule rust-lang#118137 r? ghost
[beta] Update backtrace submodule * Update backtrace submodule rust-lang#118137 As well as infrastructure fix: * Don't ask for a specific branch in cargotest rust-lang#118597 r? ghost
This PR updates the backtrace submodule, avoiding panics when resolving backtraces on Windows 7:
Fixes #117941
I ran the std unit tests locally on a Windows7 machine, and can confirm that this indeed fixes #117941.