-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ask for a specific branch in cargotest #118597
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
pls update/flesh out description :) |
Done, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing hard-coded branch name seems good to me. However, you still need to bump the commit sha of servo as it no longer exists.
Copied from CI logs
Initialized empty Git repository in /checkout/obj/build/ct/servo/.git/
fatal: Could not parse object '785a344e32db58d4e631fd3cae17fd1f29a721ab'.
fatal: couldn't find remote ref master
No, the commit exists:
(also at https://github.com/servo/servo/tree/785a344e32db58d4e631fd3cae17fd1f29a721ab) It's |
I get it now. From the following code we try to do hard-reset to specific commit hash, and in the initial iteration we haven't fetched the I don't know why |
@bors r+ p=10 |
@bors treeclosed- |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0a83e43): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.967s -> 673.138s (-0.12%) |
…Simulacrum [stable] 1.74.1 release This includes backports of: * Dispose llvm::TargetMachines prior to llvm::Context being disposed rust-lang#118464 * clarify fn discriminant guarantees: only free lifetimes may get erased rust-lang#118006 * Move subtyper below reveal_all and change reveal_all rust-lang#116415 * Make subtyping explicit in MIR rust-lang#115025 (needed for above) As well as infrastructure fix: * Don't ask for a specific branch in cargotest rust-lang#118597 r? `@Mark-Simulacrum`
[beta] Update backtrace submodule * Update backtrace submodule rust-lang#118137 As well as infrastructure fix: * Don't ask for a specific branch in cargotest rust-lang#118597 r? ghost
Tentative fix for #118592 (comment).
servo
just renamed theirmaster
branch tomain
, butcargotest
does agit fetch $URL master; git reset --hard $SHA
. Let's try to change that togit fetch $URL $SHA; git reset --hard $SHA
, which appears to work, but I can't confirm for sure because I'm having some trouble withx.py
: