Rollup of 6 pull requests #118232

matthiaskrgr · 2023-11-24T07:23:54Z

Successful merges:

Improve rewind documentation #116807 (Improve rewind documentation)
Update windows-bindgen and define INVALID_HANDLE_VALUE ourselves #117656 (Update windows-bindgen and define INVALID_HANDLE_VALUE ourselves)
chore: remove unnecessary drop #117940 (chore: remove unnecessary drop)
Document behavior of <dyn Any as Any>::type_id() #118028 (Document behavior of <dyn Any as Any>::type_id())
Use an absolute path to the NUL device #118060 (Use an absolute path to the NUL device)
Sort unstable items last in rustdoc, instead of first #118224 (Sort unstable items last in rustdoc, instead of first)

r? @ghost
@rustbot modify labels: rollup

While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly. This will also set a good example for people copying std code.

Improve rewind documentation The persistent use of an internal cursor for readers is expected for buffer data types that aren't read all at once, but for files it leads to the confusing situation where calling `read_to_end` on the same file handle multiple times only returns the contents of the file for the first call. This PR adds a note to the documentation clarifying that in that case, `rewind()` must first be called. I'm unsure if this is the right location for the docs update. Maybe it should also be duplicated on `File`?

Update windows-bindgen and define `INVALID_HANDLE_VALUE` ourselves We generate bindings to the Windows API via the `windows-bindgen` crate, which is ultimately what's also used to generate the `windows-sys` and `windows` crates. However, there currently is some custom sauce just for std which makes it a bit different from the vanilla bindings. I would love for us to reduce and eventually remove the differences entirely so that std is using the exact same bindings as everyone else. Maybe in the future we can even just have a normal dependency on `windows-sys`. This PR removes one of those special things. Our definition of `INVALID_HANDLE_VALUE` relies on an experimental nightly feature for strict provenance, so lets bring that back in house. It also excludes it from the codegen step though that isn't strictly necessary as we override it in any case. This PR also updates windows-bingen to 0.52.0.

…r=thomcc chore: remove unnecessary drop No need to manually drop since it's implicit.

Document behavior of `<dyn Any as Any>::type_id()` See also rust-lang#57893 `@rustbot` label A-docs T-libs

Use an absolute path to the NUL device While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly. This will also set a good example for people copying std code. r? libs

Sort unstable items last in rustdoc, instead of first As far as I can tell, this is a bug introduced inadvertently by rust-lang#77817 in Rust 1.49. Older toolchains used to sort unstable items last. Notice how in the code before that PR, `(Unstable, Stable) => return Ordering::Greater` in src/librustdoc/html/render/mod.rs. Whereas after that PR, `(Unstable, Stable) => return Ordering::Less`. Compare https://doc.rust-lang.org/1.48.0/std/marker/index.html vs https://doc.rust-lang.org/1.49.0/std/marker/index.html.

matthiaskrgr · 2023-11-24T07:24:11Z

@bors r+ rollup=never p=6

bors · 2023-11-24T07:24:14Z

📌 Commit 98bae81 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-11-24T09:21:27Z

⌛ Testing commit 98bae81 with merge f74f700...

bors · 2023-11-24T11:18:28Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing f74f700 to master...

rust-timer · 2023-11-24T11:20:11Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116807	Improve rewind documentation	`514c980ae8e3e5a4f6425f033485fb9476784c0c` (link)
#117656	Update windows-bindgen and define `INVALID_HANDLE_VALUE` ou…	`4edac0aa743c77527f42a13bc580e3453469bf61` (link)
#117940	chore: remove unnecessary drop	`92b05274901522da760743a855fa40affc3b184f` (link)
#118028	Document behavior of `<dyn Any as Any>::type_id()`	`a1d3759f67b0cbc91275bedfaf4da3c9a243d4e0` (link)
#118060	Use an absolute path to the NUL device	`897e35b59875bfc3b1978743e7b1a6552520cc07` (link)
#118224	Sort unstable items last in rustdoc, instead of first	`d2470a5ce1532b9cf6a42b8004ca35d6b8182434` (link)

previous master: 8abf920985

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-11-24T13:42:34Z

Finished benchmarking commit (f74f700): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.2%	[1.7%, 8.0%]	3
Regressions ❌ (secondary)	1.3%	[1.3%, 1.3%]	1
Improvements ✅ (primary)	-3.3%	[-3.9%, -2.6%]	2
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	1.2%	[-3.9%, 8.0%]	5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.4%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	5
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	4
All ❌✅ (primary)	0.0%	[-0.2%, 0.4%]	10

Bootstrap: 675.075s -> 678.134s (0.45%)
Artifact size: 313.48 MiB -> 313.53 MiB (0.01%)

seanlinsley and others added 14 commits October 16, 2023 12:41

Improve rewind documentation

1fb0033

remove unnecessary drop

a355df4

Define INVALID_HANDLE_VALUE ourselves

df58704

Update windows-bindgen

00a12af

Document behavior of <dyn Any as Any>::type_id()

db62921

See also rust-lang#57893

Use an absolute path to the NUL device

3a486c1

While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly. This will also set a good example for people copying std code.

Add test of rustdoc sort order for stable vs unstable item

a994f46

Sort unstable items last in rustdoc, instead of first

b77aa74

Rollup merge of rust-lang#117940 - zhiqiangxu:remove_redundant_drop, …

f38de06

…r=thomcc chore: remove unnecessary drop No need to manually drop since it's implicit.

Rollup merge of rust-lang#118028 - Jules-Bertholet:dyn-any-doc, r=thomcc

c3216e2

Document behavior of `<dyn Any as Any>::type_id()` See also rust-lang#57893 `@rustbot` label A-docs T-libs

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2023

bors merged commit f74f700 into rust-lang:master Nov 24, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Nov 24, 2023

bors mentioned this pull request Nov 24, 2023

windows: provide more accurate result for available_parallelism if cores > 64 #114856

Closed

This was referenced Nov 24, 2023

rename ptr::invalid -> ptr::without_provenance #117658

Merged

De-emphasize unstable items in rustdoc item table #118226

Closed

matthiaskrgr deleted the rollup-x8crvm0 branch March 16, 2024 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #118232

Rollup of 6 pull requests #118232

matthiaskrgr commented Nov 24, 2023

matthiaskrgr commented Nov 24, 2023

bors commented Nov 24, 2023

bors commented Nov 24, 2023

bors commented Nov 24, 2023

rust-timer commented Nov 24, 2023

rust-timer commented Nov 24, 2023

Rollup of 6 pull requests #118232

Rollup of 6 pull requests #118232

Conversation

matthiaskrgr commented Nov 24, 2023

matthiaskrgr commented Nov 24, 2023

bors commented Nov 24, 2023

bors commented Nov 24, 2023

bors commented Nov 24, 2023

rust-timer commented Nov 24, 2023

rust-timer commented Nov 24, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size