Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #118232

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Rollup of 6 pull requests #118232

merged 14 commits into from
Nov 24, 2023

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    1fb0033 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. remove unnecessary drop

    zhiqiangxu authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a355df4 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Configuration menu
    Copy the full SHA
    df58704 View commit details
    Browse the repository at this point in the history
  2. Update windows-bindgen

    ChrisDenton committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    00a12af View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Configuration menu
    Copy the full SHA
    db62921 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Use an absolute path to the NUL device

    While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly.
    
    This will also set a good example for people copying std code.
    ChrisDenton committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    3a486c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    a994f46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b77aa74 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#116807 - seanlinsley:patch-2, r=thomcc

    Improve rewind documentation
    
    The persistent use of an internal cursor for readers is expected for buffer data types that aren't read all at once, but for files it leads to the confusing situation where calling `read_to_end` on the same file handle multiple times only returns the contents of the file for the first call. This PR adds a note to the documentation clarifying that in that case, `rewind()` must first be called.
    
    I'm unsure if this is the right location for the docs update. Maybe it should also be duplicated on `File`?
    matthiaskrgr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b865709 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#117656 - ChrisDenton:invalid, r=thomcc

    Update windows-bindgen and define `INVALID_HANDLE_VALUE` ourselves
    
    We generate bindings to the Windows API via the `windows-bindgen` crate, which is ultimately what's also used to generate the `windows-sys` and `windows` crates. However, there currently is some custom sauce just for std which makes it a bit different from the vanilla bindings. I would love for us to reduce and eventually remove the differences entirely so that std is using the exact same bindings as everyone else. Maybe in the future we can even just have a normal dependency on `windows-sys`.
    
    This PR removes one of those special things. Our definition of `INVALID_HANDLE_VALUE` relies on an experimental nightly feature for strict provenance, so lets bring that back in house. It also excludes it from the codegen step though that isn't strictly necessary as we override it in any case.
    
    This PR also updates windows-bingen to 0.52.0.
    matthiaskrgr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7e3ec1b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#117940 - zhiqiangxu:remove_redundant_drop, …

    …r=thomcc
    
    chore: remove unnecessary drop
    
     No need to manually drop since it's implicit.
    matthiaskrgr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    f38de06 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#118028 - Jules-Bertholet:dyn-any-doc, r=thomcc

    Document behavior of `<dyn Any as Any>::type_id()`
    
    See also rust-lang#57893
    
    `@rustbot` label A-docs T-libs
    matthiaskrgr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    c3216e2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#118060 - ChrisDenton:abs-device-path, r=thomcc

    Use an absolute path to the NUL device
    
    While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly.
    
    This will also set a good example for people copying std code.
    
    r? libs
    matthiaskrgr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b2d6480 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#118224 - dtolnay:rustdocsortunstable, r=fmease

    Sort unstable items last in rustdoc, instead of first
    
    As far as I can tell, this is a bug introduced inadvertently by rust-lang#77817 in Rust 1.49. Older toolchains used to sort unstable items last.
    
    Notice how in the code before that PR, `(Unstable, Stable) => return Ordering::Greater` in src/librustdoc/html/render/mod.rs. Whereas after that PR, `(Unstable, Stable) => return Ordering::Less`.
    
    Compare https://doc.rust-lang.org/1.48.0/std/marker/index.html vs https://doc.rust-lang.org/1.49.0/std/marker/index.html.
    matthiaskrgr authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    98bae81 View commit details
    Browse the repository at this point in the history