-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make traits / trait methods detected by the dead code lint #118257
Conversation
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
This comment was marked as outdated.
This comment was marked as outdated.
Does it manly just affect tests? If that's the case we can just put In any case could you post (via pastebin or something else, since GitHub will probably limit you) the full output of the new warnings. So we can get a sense of scale of new warnings. |
Ui tests allow unused code lint by default. So there is nothing to do on most. |
In #92790 / #95977, I also caused a lot of new warnings to show up :-) There we started the lint as allow-by-default (and appear to still treat it as such... I should look into that). Perhaps we start the same way here? |
This comment has been minimized.
This comment has been minimized.
9fc34e3
to
f10c6a8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6bdbc3a
to
a6f59a5
Compare
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes might have occurred in exhaustiveness checking cc @Nadrieril |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
254bb8a
to
412c984
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Could you extract the cleanups you do to the rest of the compiler to a standalone PR? |
tests/codegen-units/item-collection/instantiation-through-vtable.rs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
6cf287f
to
d609000
Compare
This comment has been minimized.
This comment has been minimized.
8fd5b26
to
c7519d4
Compare
☀️ Test successful - checks-actions |
Finished benchmarking commit (d4f6f9e): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 663.003s -> 664.334s (0.20%) |
High-level check on the perf results...
|
Regression: #120770. |
rust-lang/rust#118257 has improved the detection of unused traits
The compiler now does more work, so some small regressions are expected. The large regression is from initializing diagnostics (there were no warning produced before for that stress test), so that is fine, as it's a one-time cost. @rustbot label: +perf-regression-triaged |
Remove dead codes in rustc_codegen_gcc Detected by rust-lang#118257
Fixes #118139 and #41883