Skip to content

Remove dead codes in rustc_codegen_gcc #118828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2023
Merged

Remove dead codes in rustc_codegen_gcc #118828

merged 1 commit into from
Dec 17, 2023

Conversation

mu001999
Copy link
Contributor

Detected by #118257

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2023

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@mu001999 mu001999 changed the title Remove dead codes Remove dead codes in rustc_codegen_gcc Dec 12, 2023
@b-naber
Copy link
Contributor

b-naber commented Dec 16, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 16, 2023

📌 Commit 2bc60fd has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 16, 2023
@matthiaskrgr
Rollup merge of rust-lang#118828 - mu001999:master, r=b-naber
5eddd5b 
Remove dead codes in rustc_codegen_gcc

Detected by rust-lang#118257
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
@bors
Auto merge of rust-lang#119018 - matthiaskrgr:rollup-inlg0yr, r=matth…
5df5022 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#118644 (Add test for Apple's `-weak_framework` linker argument)
 - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc)
 - rust-lang#119001 (rustdoc-search: remove parallel searchWords array)

r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 16, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 16, 2023
@GuillaumeGomez
Rollup merge of rust-lang#118828 - mu001999:master, r=b-naber
5ef9ed2 
Remove dead codes in rustc_codegen_gcc

Detected by rust-lang#118257
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
@bors
Auto merge of rust-lang#119027 - GuillaumeGomez:rollup-bcxuwn7, r=Gui…
abaf2e8 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#118644 (Add test for Apple's `-weak_framework` linker argument)
 - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc)
 - rust-lang#118830 (Add support for `--env` on `tracked_env::var`)
 - rust-lang#119001 (rustdoc-search: remove parallel searchWords array)
 - rust-lang#119020 (remove `hex` dependency in bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 16, 2023
@GuillaumeGomez
Rollup merge of rust-lang#118828 - mu001999:master, r=b-naber
9c6426b 
Remove dead codes in rustc_codegen_gcc

Detected by rust-lang#118257
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 16, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2023
@bors
Auto merge of rust-lang#119030 - GuillaumeGomez:rollup-sb5e7wi, r=Gui…
1ed2eb8 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc)
 - rust-lang#118830 (Add support for `--env` on `tracked_env::var`)
 - rust-lang#119001 (rustdoc-search: remove parallel searchWords array)
 - rust-lang#119011 (coverage: Regression test for `assert!(!false)`)
 - rust-lang#119020 (remove `hex` dependency in bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Dec 17, 2023

⌛ Testing commit 2bc60fd with merge 6135585...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2023
@bors
Auto merge of rust-lang#118828 - mu001999:master, r=b-naber
6135585 
Remove dead codes in rustc_codegen_gcc

Detected by rust-lang#118257
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Dec 17, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2023
@b-naber
Copy link
Contributor

b-naber commented Dec 17, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2023
@bors
Copy link
Collaborator

bors commented Dec 17, 2023

⌛ Testing commit 2bc60fd with merge e95a69d...

@bors
Copy link
Collaborator

bors commented Dec 17, 2023

☀️ Test successful - checks-actions
Approved by: b-naber
Pushing e95a69d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2023
@bors bors merged commit e95a69d into rust-lang:master Dec 17, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 17, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e95a69d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.8% [3.8%, 3.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.366s -> 671.333s (-0.00%)
Artifact size: 312.39 MiB -> 312.44 MiB (0.02%)

GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2024
@bors
Auto merge of rust-lang#118828 - mu001999:master, r=b-naber
335e3ec 
Remove dead codes in rustc_codegen_gcc

Detected by rust-lang#118257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@b-naber b-naber

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mu001999 @rustbot @b-naber @bors @rust-log-analyzer @rust-timer