-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #118405
Rollup of 7 pull requests #118405
Conversation
…ple, and expand on existing example.
This cuts >100kb from a local librustc_driver.so build, and seems just obviously simpler.
this avoids part of the char decoding work by not looking at utf8 continuation bytes
For these two methods, `other` is an ordinary unsigned integer, so it can be zero. Since the sum of non-zero and zero is always non-zero, the safety argument holds even when `other` is zero.
optimize str::iter::Chars::advance_by ``` OLD: str::iter::chars_advance_by_0001 0.00ns/iter +/- 0.00ns str::iter::chars_advance_by_0010 13.00ns/iter +/- 1.00ns str::iter::chars_advance_by_1000 1.20µs/iter +/- 15.00ns NEW: str::iter::chars_advance_by_0001 0.00ns/iter +/- 0.00ns str::iter::chars_advance_by_0010 6.00ns/iter +/- 0.00ns str::iter::chars_advance_by_1000 75.00ns/iter +/- 1.00ns ```
Update mod comment The comment of `ASCII_CASE_MASK` on line 477 is `If 6th bit is set ascii is lower case.` but the original comment of `*self ^ ((self.is_ascii_lowercase() as u8) * ASCII_CASE_MASK)` was `Toggle the fifth bit if this is a lowercase letter`
Update `OnceLock` documentation to give a concrete 'lazy static' example, and expand on the existing example.
…ts, r=cuviper Rename `{collections=>alloc}{tests,benches}` The crate is named `alloc` so this makes more sense. Ig this is fallout from rust-lang#42648?
… r=compiler-errors Simplify indenting in THIR printing This cuts >100kb from a local librustc_driver.so build, and seems just obviously simpler.
…t-repr, r=compiler-errors Detect and reject malformed `repr(Rust)` hints Fixes rust-lang#118334.
Fix comments for unsigned non-zero `checked_add`, `saturating_add` While looking at rust-lang#118313, I happened to notice that two of the expanded comments appear to be slightly inaccurate. For these two methods, `other` is an ordinary unsigned integer, so it can be zero. Since the sum of non-zero and zero is always non-zero, the safety argument holds even when `other` is zero.
@bors r+ rollup=never p=7 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: e06c94d6cb In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (46a24ed): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 673.509s -> 672.848s (-0.10%) |
Successful merges:
OnceLock
documentation to give a concrete 'lazy static' example, and expand on the existing example. #118299 (UpdateOnceLock
documentation to give a concrete 'lazy static' example, and expand on the existing example.){collections=>alloc}{tests,benches}
#118314 (Rename{collections=>alloc}{tests,benches}
)repr(Rust)
hints #118366 (Detect and reject malformedrepr(Rust)
hints)checked_add
,saturating_add
#118397 (Fix comments for unsigned non-zerochecked_add
,saturating_add
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup