Add tests related to normalization in implied bounds #118512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r- Let's actually include a test with the Bevy regression here too. |
bors
added
S-waiting-on-author
spastorino
force-pushed
the
add-implied-bounds-related-tests
branch
2 times, most recently
from
adea760 to
b846fe0
Compare
jackh726
requested changes
Dec 8, 2023
| @@ -0,0 +1,20 @@ | |||
| // Related to Bevy regression #118553 | |||
|
|
|||
| pub mod system { | |||
There was a problem hiding this comment.
Please just online this into the test itself - the special casing does not use the path.
| // aux-crate:bevy_ecs=bevy_ecs.rs | ||
| // check-pass | ||
|
|
||
| // We currently special case bevy from emitting the `IMPLIED_BOUNDS_FROM_TRAIT_IMPL` lint. |
There was a problem hiding this comment.
This comment needs to be updated - no special casing yet.
| @@ -0,0 +1,29 @@ | |||
| // check-pass | |||
|
|
|||
There was a problem hiding this comment.
Please add a comment where this comes from.
spastorino
force-pushed
the
add-implied-bounds-related-tests
branch
from
b846fe0 to
7079adb
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…ted-tests, r=jackh726 Add tests related to normalization in implied bounds Getting `@aliemjay's` tests from rust-lang#109763, so we can better track what's going on in every different example. r? `@jackh726`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…ted-tests, r=jackh726 Add tests related to normalization in implied bounds Getting ``@aliemjay's`` tests from rust-lang#109763, so we can better track what's going on in every different example. r? ``@jackh726``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions) - rust-lang#118512 (Add tests related to normalization in implied bounds) - rust-lang#118610 (update target feature following LLVM API change) - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) - rust-lang#118756 (use bold magenta instead of bold white for highlighting) - rust-lang#118762 (Some more minor `async gen`-related nits) - rust-lang#118764 (Make async generators fused by default) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions) - rust-lang#118512 (Add tests related to normalization in implied bounds) - rust-lang#118610 (update target feature following LLVM API change) - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) - rust-lang#118762 (Some more minor `async gen`-related nits) - rust-lang#118764 (Make async generators fused by default) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
Rollup merge of rust-lang#118512 - spastorino:add-implied-bounds-related-tests, r=jackh726 Add tests related to normalization in implied bounds Getting ```@aliemjay's``` tests from rust-lang#109763, so we can better track what's going on in every different example. r? ```@jackh726```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting @aliemjay's tests from #109763, so we can better track what's going on in every different example.
r? @jackh726