-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend tidy alphabetical checking to tests/
.
#118737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is desired for rust-lang#118702.
r? @onur-ozkan (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Dec 8, 2023
Urgau
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this change in #118702. Works as expected.
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 8, 2023
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ``@Nilstrieb``
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ````@Nilstrieb````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 8, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118150 (Add new targets {x86_64,i686}-win7-windows-msvc) - rust-lang#118417 (Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`.) - rust-lang#118692 (remove redundant imports) - rust-lang#118694 (Add instance evaluation and methods to read an allocation in StableMIR) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) r? `@ghost` `@rustbot` modify labels: rollup
@bors rollup |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? `@Nilstrieb`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ``@Nilstrieb``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions) - rust-lang#118512 (Add tests related to normalization in implied bounds) - rust-lang#118610 (update target feature following LLVM API change) - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) - rust-lang#118756 (use bold magenta instead of bold white for highlighting) - rust-lang#118762 (Some more minor `async gen`-related nits) - rust-lang#118764 (Make async generators fused by default) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#118198 (coverage: Use `SpanMarker` to improve coverage spans for `if !` expressions) - rust-lang#118512 (Add tests related to normalization in implied bounds) - rust-lang#118610 (update target feature following LLVM API change) - rust-lang#118666 (coverage: Simplify the heuristic for ignoring `async fn` return spans) - rust-lang#118737 (Extend tidy alphabetical checking to `tests/`.) - rust-lang#118762 (Some more minor `async gen`-related nits) - rust-lang#118764 (Make async generators fused by default) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
Rollup merge of rust-lang#118737 - nnethercote:tidy-alphabetical-in-testsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is desired for #118702.
r? @Nilstrieb