Strengthen well known check-cfg names and values test #118702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
nnethercote
reviewed
Dec 7, 2023
I generally put these kinds of changes into separate commits. It makes the reviewer's job easier when unrelated changes are separated out. |
Urgau
force-pushed
the
check-cfg-strengthen-well-known
branch
from
5bfb9f5
to
455d583
Compare
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Dec 8, 2023
This is desired for rust-lang#118702.
Urgau
force-pushed
the
check-cfg-strengthen-well-known
branch
from
455d583
to
28524b3
Compare
nnethercote
reviewed
Dec 8, 2023
|
✌️ @Urgau, you can now approve this pull request! If @nnethercote told you to " |
Urgau
force-pushed
the
check-cfg-strengthen-well-known
branch
from
28524b3
to
5a17ee7
Compare
|
@bors r=@nnethercote rollup=always |
|
@Urgau: 🔑 Insufficient privileges: Not in reviewers |
|
@Urgau: 🔑 Insufficient privileges: not in try users |
|
@bors r=nnethercote |
|
@Urgau: 🔑 Insufficient privileges: Not in reviewers |
|
Weird. Oh well. @bors r=nnethercote rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? ``@nnethercote`` (maybe? feel free to re-assign)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ``@Nilstrieb``
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? ```@nnethercote``` (maybe? feel free to re-assign)
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```
|
Failed in #118744. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 8, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ````@Nilstrieb````
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? `@Nilstrieb`
|
@bors r- |
bors
added
S-waiting-on-author
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ``@Nilstrieb``
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Dec 9, 2023
…estsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```
as they unnecessarily clutter the diagnostic output and make the experience of adding a new target to the compiler more painful than it should be. target_os and target_arch are still being tested in the well-known-values.rs test, but in one place.
Urgau
force-pushed
the
check-cfg-strengthen-well-known
branch
from
5a17ee7
to
4c16716
Compare
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
Rollup merge of rust-lang#118737 - nnethercote:tidy-alphabetical-in-testsa, r=Nilstrieb Extend tidy alphabetical checking to `tests/`. This is desired for rust-lang#118702. r? ```@Nilstrieb```
|
I've rebased and re-blessed the diagnostic output (new win7 target). @rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r=nnethercote |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#117953 (Add more SIMD platform-intrinsics) - rust-lang#118057 (dedup for duplicate suggestions) - rust-lang#118638 (More `rustc_mir_dataflow` cleanups) - rust-lang#118702 (Strengthen well known check-cfg names and values test) - rust-lang#118734 (Unescaping cleanups) - rust-lang#118766 (Lower some forgotten spans) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2023
Rollup merge of rust-lang#118702 - Urgau:check-cfg-strengthen-well-known, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them.
This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry.
this PR also contains some drive-by consolidation of unexpected
target_os,target_archinto a single filer? @nnethercote (maybe? feel free to re-assign)