Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag #118521

dpaoliello · 2023-12-01T22:34:09Z

This enables address sanitizer for x86_64-pc-windows-msvc and i686-pc-windows-msvc targets when linked with the MSVC linker (link.exe) by leveraging the /INFERASANLIBS option to automatically find and link in Microsoft's address sanitizer runtime: https://learn.microsoft.com/en-us/cpp/sanitizers/asan-runtime?view=msvc-170

Implements rust-lang/compiler-team#702
Fixes #89339 (for MSVC targets using the MSVC linker only)
Supercedes #89369

Successful x86_64-msvc build showing the sanitizer tests working: https://github.com/rust-lang/rust/actions/runs/7228346880/job/19697628258?pr=118521

rustbot · 2023-12-01T22:34:16Z

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

dpaoliello · 2023-12-02T00:11:31Z

@bors try

bors · 2023-12-02T00:11:34Z

@dpaoliello: 🔑 Insufficient privileges: not in try users

arlosi · 2023-12-06T21:17:25Z

@bors try

bors · 2023-12-06T21:18:36Z

⌛ Trying commit 913f7d5 with merge 2d27f83...

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag

bors · 2023-12-06T22:45:16Z

☀️ Try build successful - checks-actions
Build commit: 2d27f83 (2d27f8383b55fbb6c155c75b62afb30fbbc075ec)

compiler/rustc_codegen_ssa/src/back/link.rs

compiler/rustc_session/src/session.rs

wesleywiser · 2023-12-12T18:42:09Z

@bors try

bors · 2023-12-12T18:43:18Z

⌛ Trying commit 577799d with merge 25018d2...

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag

bors · 2023-12-12T18:45:50Z

💔 Test failed - checks-actions

wesleywiser · 2023-12-12T18:59:15Z

@bors try

bors · 2023-12-12T19:00:24Z

⌛ Trying commit 182ea6f with merge d8386fb...

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag

bors · 2023-12-12T20:24:15Z

☀️ Try build successful - checks-actions
Build commit: d8386fb (d8386fb03fbdfb74a558ef072ea726ed06ae9a4c)

rustbot · 2023-12-22T18:11:54Z

These commits modify compiler targets.
(See the Target Tier Policy.)

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

bors · 2023-12-26T05:12:28Z

☔ The latest upstream changes (presumably #119146) made this pull request unmergeable. Please resolve the merge conflicts.

wesleywiser · 2024-01-03T17:54:02Z

r? wesleywiser

…flag

wesleywiser · 2024-01-03T19:55:01Z

Thanks @dpaoliello, it's exciting to have address sanitizer support on Windows!

@bors r+

bors · 2024-01-03T19:55:04Z

📌 Commit bc3b7c9 has been approved by wesleywiser

It is now in the queue for this repository.

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag This enables address sanitizer for x86_64-pc-windows-msvc and i686-pc-windows-msvc targets when linked with the MSVC linker (link.exe) by leveraging the `/INFERASANLIBS` option to automatically find and link in Microsoft's address sanitizer runtime: <https://learn.microsoft.com/en-us/cpp/sanitizers/asan-runtime?view=msvc-170> Implements rust-lang/compiler-team#702 Fixes rust-lang#89339 (for MSVC targets using the MSVC linker only) Supercedes rust-lang#89369 Successful x86_64-msvc build showing the sanitizer tests working: https://github.com/rust-lang/rust/actions/runs/7228346880/job/19697628258?pr=118521

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117449 (Avoid silencing relevant follow-up errors) - rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint) - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag) - rust-lang#118704 (Promote `riscv32{im|imafc}` targets to tier 2) - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions) - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args) r? `@ghost` `@rustbot` modify labels: rollup

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag This enables address sanitizer for x86_64-pc-windows-msvc and i686-pc-windows-msvc targets when linked with the MSVC linker (link.exe) by leveraging the `/INFERASANLIBS` option to automatically find and link in Microsoft's address sanitizer runtime: <https://learn.microsoft.com/en-us/cpp/sanitizers/asan-runtime?view=msvc-170> Implements rust-lang/compiler-team#702 Fixes rust-lang#89339 (for MSVC targets using the MSVC linker only) Supercedes rust-lang#89369 Successful x86_64-msvc build showing the sanitizer tests working: https://github.com/rust-lang/rust/actions/runs/7228346880/job/19697628258?pr=118521

…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag) - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args) - rust-lang#119204 (macro_rules: Less hacky heuristic for using `tt` metavariable spans) - rust-lang#119362 (Make `derive(Trait)` suggestion more accurate) - rust-lang#119397 (Recover parentheses in range patterns) - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo) - rust-lang#119417 (Uplift some miscellaneous coroutine-specific machinery into `check_closure`) - rust-lang#119540 (Don't synthesize host effect args inside trait object types) - rust-lang#119555 (Add codegen test for RVO on MaybeUninit) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag) - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.) - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args) - rust-lang#119204 (macro_rules: Less hacky heuristic for using `tt` metavariable spans) - rust-lang#119362 (Make `derive(Trait)` suggestion more accurate) - rust-lang#119397 (Recover parentheses in range patterns) - rust-lang#119417 (Uplift some miscellaneous coroutine-specific machinery into `check_closure`) - rust-lang#119539 (Fix typos) - rust-lang#119540 (Don't synthesize host effect args inside trait object types) - rust-lang#119555 (Add codegen test for RVO on MaybeUninit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118521 - dpaoliello:asan, r=wesleywiser Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag This enables address sanitizer for x86_64-pc-windows-msvc and i686-pc-windows-msvc targets when linked with the MSVC linker (link.exe) by leveraging the `/INFERASANLIBS` option to automatically find and link in Microsoft's address sanitizer runtime: <https://learn.microsoft.com/en-us/cpp/sanitizers/asan-runtime?view=msvc-170> Implements rust-lang/compiler-team#702 Fixes rust-lang#89339 (for MSVC targets using the MSVC linker only) Supercedes rust-lang#89369 Successful x86_64-msvc build showing the sanitizer tests working: https://github.com/rust-lang/rust/actions/runs/7228346880/job/19697628258?pr=118521

rustbot assigned clubby789 Dec 1, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2023

Auto merge of rust-lang#118521 - dpaoliello:asan, r=<try>

2d27f83

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag

dpaoliello mentioned this pull request Dec 7, 2023

Use the MSVC provided Address Sanitizer runtime when building for MSVC rust-lang/compiler-team#702

Closed

3 tasks

wesleywiser reviewed Dec 12, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/back/link.rs Show resolved Hide resolved

compiler/rustc_session/src/session.rs Show resolved Hide resolved

dpaoliello force-pushed the asan branch from 913f7d5 to 7fe58da Compare December 12, 2023 18:30

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 12, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2023

Auto merge of rust-lang#118521 - dpaoliello:asan, r=<try>

25018d2

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2023

dpaoliello force-pushed the asan branch from 577799d to 7d7d8dc Compare December 12, 2023 18:48

This comment has been minimized.

Sign in to view

dpaoliello force-pushed the asan branch from 7d7d8dc to 182ea6f Compare December 12, 2023 18:58

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2023

Auto merge of rust-lang#118521 - dpaoliello:asan, r=<try>

d8386fb

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag

dpaoliello force-pushed the asan branch from d2279f8 to 19f53d7 Compare December 22, 2023 18:11

dpaoliello marked this pull request as ready for review December 22, 2023 18:11

rustbot assigned wesleywiser and unassigned clubby789 Jan 3, 2024

Enable address sanitizer for MSVC targets using INFERASANLIBS linker …

bc3b7c9

…flag

dpaoliello force-pushed the asan branch from 19f53d7 to bc3b7c9 Compare January 3, 2024 18:00

wesleywiser approved these changes Jan 3, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 3, 2024

matthiaskrgr mentioned this pull request Jan 3, 2024

Rollup of 7 pull requests #119558

Closed

compiler-errors mentioned this pull request Jan 4, 2024

Rollup of 10 pull requests #119565

Closed

matthiaskrgr mentioned this pull request Jan 4, 2024

Rollup of 10 pull requests #119569

Merged

bors merged commit 1f32203 into rust-lang:master Jan 4, 2024

rustbot added this to the 1.77.0 milestone Jan 4, 2024

dpaoliello deleted the asan branch January 5, 2024 00:13

Eh2406 mentioned this pull request Jan 7, 2024

Improve integration on MSVC rust-fuzz/cargo-fuzz#358

Open

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag #118521

Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag #118521

Uh oh!

Conversation

dpaoliello commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 1, 2023

Uh oh!

dpaoliello commented Dec 2, 2023

Uh oh!

bors commented Dec 2, 2023

Uh oh!

arlosi commented Dec 6, 2023

Uh oh!

bors commented Dec 6, 2023

Uh oh!

bors commented Dec 6, 2023

Uh oh!

Uh oh!

Uh oh!

wesleywiser commented Dec 12, 2023

Uh oh!

bors commented Dec 12, 2023

Uh oh!

This comment has been minimized.

bors commented Dec 12, 2023

Uh oh!

This comment has been minimized.

wesleywiser commented Dec 12, 2023

Uh oh!

bors commented Dec 12, 2023

Uh oh!

bors commented Dec 12, 2023

Uh oh!

rustbot commented Dec 22, 2023

Uh oh!

bors commented Dec 26, 2023

Uh oh!

wesleywiser commented Jan 3, 2024

Uh oh!

wesleywiser commented Jan 3, 2024

Uh oh!

bors commented Jan 3, 2024

Uh oh!

Uh oh!

dpaoliello commented Dec 1, 2023 •

edited

Loading