Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide foreign #[doc(hidden)] paths in import suggestions #119151

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Hide foreign #[doc(hidden)] paths in import suggestions #119151

merged 1 commit into from
Jan 5, 2024

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Dec 20, 2023 •
edited
Loading

Stops the compiler from suggesting to import foreign #[doc(hidden)] paths.

@rustbot label A-suggestion-diagnostics

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` labels Dec 20, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet Jules-Bertholet force-pushed the no-foreign-doc-hidden-suggest branch from 7e0a0b0 to 52c5d77 Compare December 20, 2023 04:19
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet Jules-Bertholet force-pushed the no-foreign-doc-hidden-suggest branch from 52c5d77 to 5c0e62c Compare December 20, 2023 05:20
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

davidtwco
davidtwco approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth doing. I'm a little cautious of using #[doc(hidden)] for anything other than hiding documentation, but given that this is only for diagnostics then that's probably okay.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2024

📌 Commit 5c0e62c has been approved by davidtwco

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 3, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 3, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hid…
d00fb50 
…den-suggest, r=davidtwco

Hide foreign `#[doc(hidden)]` paths in import suggestions

Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths.

`@rustbot` label A-suggestion-diagnostics
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2024
@bors
Auto merge of rust-lang#119558 - matthiaskrgr:rollup-ghm80lp, r=matth…
1627c60 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117449 (Avoid silencing relevant follow-up errors)
 - rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint)
 - rust-lang#118521 (Enable address sanitizer for MSVC targets using INFERASANLIBS linker flag)
 - rust-lang#118704 (Promote `riscv32{im|imafc}` targets to tier 2)
 - rust-lang#119026 (std::net::bind using -1 for openbsd which in turn sets it to somaxconn.)
 - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions)
 - rust-lang#119195 (Make named_asm_labels lint not trigger on unicode and trigger on format args)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hid…
33d1c50 
…den-suggest, r=davidtwco

Hide foreign `#[doc(hidden)]` paths in import suggestions

Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths.

``@rustbot`` label A-suggestion-diagnostics
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@bors
Auto merge of rust-lang#119603 - matthiaskrgr:rollup-ulep7qk, r=matth…
2b68104 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118680 (Add support for shell argfiles)
 - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions)
 - rust-lang#119216 (Use diagnostic namespace in stdlib)
 - rust-lang#119350 (Imply outlives-bounds on lazy type aliases)
 - rust-lang#119538 (Cleanup error handlers: round 5)
 - rust-lang#119563 (Check yield terminator's resume type in borrowck)
 - rust-lang#119589 (cstore: Remove unnecessary locking from `CrateMetadata`)
 - rust-lang#119591 (rustc_mir_transform: Make DestinationPropagation stable for queries)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
I think this failed in #119603 (comment) ?

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2024
@fmease
Copy link
Member

fmease commented Jan 5, 2024

Nope, that's #119216's “fault”. CC #119597, #119216 (comment).

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jan 5, 2024

📌 Commit 5c0e62c has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hid…
cf4d1c3 
…den-suggest, r=davidtwco

Hide foreign `#[doc(hidden)]` paths in import suggestions

Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths.

`@rustbot` label A-suggestion-diagnostics
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hid…
7a00ce6 
…den-suggest, r=davidtwco

Hide foreign `#[doc(hidden)]` paths in import suggestions

Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths.

``@rustbot`` label A-suggestion-diagnostics
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@bors
Auto merge of rust-lang#119630 - matthiaskrgr:rollup-oymvjkn, r=matth…
3db2c3b 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118680 (Add support for shell argfiles)
 - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions)
 - rust-lang#119350 (Imply outlives-bounds on lazy type aliases)
 - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues)
 - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`)
 - rust-lang#119554 (Fix scoping for let chains in match guards)
 - rust-lang#119563 (Check yield terminator's resume type in borrowck)
 - rust-lang#119589 (cstore: Remove unnecessary locking from `CrateMetadata`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@bors
Auto merge of rust-lang#119634 - matthiaskrgr:rollup-v2xt7et, r=matth…
595bc6f 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions)
 - rust-lang#119350 (Imply outlives-bounds on lazy type aliases)
 - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues)
 - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`)
 - rust-lang#119554 (Fix scoping for let chains in match guards)
 - rust-lang#119563 (Check yield terminator's resume type in borrowck)
 - rust-lang#119589 (cstore: Remove unnecessary locking from `CrateMetadata`)
 - rust-lang#119622 (never patterns: Document behavior of never patterns with macros-by-example)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3a0536a into rust-lang:master Jan 5, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@rust-timer
Unrolled build for rust-lang#119151
ed7e1cc 
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hidden-suggest, r=davidtwco

Hide foreign `#[doc(hidden)]` paths in import suggestions

Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths.

```@rustbot``` label A-suggestion-diagnostics
@Jules-Bertholet Jules-Bertholet deleted the no-foreign-doc-hidden-suggest branch January 6, 2024 02:31
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 11, 2024
@matthiaskrgr
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hid…
b418117 
…den-suggest, r=davidtwco

Hide foreign `#[doc(hidden)]` paths in import suggestions

Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths.

```@rustbot``` label A-suggestion-diagnostics
@dtolnay dtolnay mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Jules-Bertholet @rustbot @rust-log-analyzer @davidtwco @bors @matthiaskrgr @fmease