Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use c literals in compiler and library #118566

Merged
merged 2 commits into from
Dec 14, 2023
Merged

use c literals in compiler and library #118566

merged 2 commits into from
Dec 14, 2023

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Dec 3, 2023

Relands refreshed #111647

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@y21 y21 mentioned this pull request Dec 4, 2023
Merged
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2023

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@klensy
Copy link
Contributor Author

klensy commented Dec 14, 2023

r? compiler

@rustbot rustbot assigned WaffleLapkin and unassigned b-naber Dec 14, 2023
@WaffleLapkin
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 14, 2023

📌 Commit c013488 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023
@bors
Copy link
Contributor

bors commented Dec 14, 2023

⌛ Testing commit c013488 with merge 1aa6aef...

@bors
Copy link
Contributor

bors commented Dec 14, 2023

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing 1aa6aef to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Dec 14, 2023

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing 1aa6aef to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 14, 2023
@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 14, 2023
@bors bors merged commit 1aa6aef into rust-lang:master Dec 14, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 14, 2023
This was referenced Dec 14, 2023
Open
Merged
Closed
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1aa6aef): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.5%, 0.7%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.7%, -0.4%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.7%, 0.7%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.5% [1.5%, 1.5%] 1
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [-0.4%, 1.5%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.776s -> 671.102s (0.05%)
Artifact size: 312.39 MiB -> 312.48 MiB (0.03%)

@celinval celinval mentioned this pull request Dec 15, 2023
Merged
adpaco-aws pushed a commit to model-checking/kani that referenced this pull request Dec 15, 2023
@celinval
Update nightly toolchain to toolchain-2023-12-15 (#2948)
24ececc 
Related PR: rust-lang/rust#118566

Resolves #2946
@wesleywiser wesleywiser mentioned this pull request Jan 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2024
@bors
Auto merge of rust-lang#119528 - wesleywiser:revert_117472, r=nnether…
0fb6e6b 
…cote

[beta] Revert rust-lang#117472: Stabilize C string literals

Based on discussion in [#t-lang](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/rfc.203349.3A.20mixed.20utf8.20literals), revert the stabilization of C string literals in Rust 1.76.

I also reverted rust-lang#118566 as it uses the newly stabilized C string literals in various places.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2024
@bors
Auto merge of rust-lang#119528 - wesleywiser:revert_117472, r=nnether…
c4cf95c 
…cote

[beta] Revert rust-lang#117472: Stabilize C string literals

Based on discussion in [#t-lang](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/rfc.203349.3A.20mixed.20utf8.20literals), revert the stabilization of C string literals in Rust 1.76.

I also reverted rust-lang#118566 as it uses the newly stabilized C string literals in various places.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2024
@bors
Auto merge of rust-lang#119528 - wesleywiser:revert_117472, r=nnether…
3a3478e 
…cote

[beta] Revert rust-lang#117472: Stabilize C string literals

Based on discussion in [#t-lang](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/rfc.203349.3A.20mixed.20utf8.20literals), revert the stabilization of C string literals in Rust 1.76.

I also reverted rust-lang#118566 as it uses the newly stabilized C string literals in various places.
cuviper added a commit to cuviper/rust that referenced this pull request Aug 20, 2024
@cuviper
Avoid extra cast()s after CStr::as_ptr()
e424e7f 
These used to be `&str` literals that did need a pointer cast, but that
became a no-op after switching to `c""` literals in rust-lang#118566.
@cuviper cuviper mentioned this pull request Aug 20, 2024
Merged
tgross35 added a commit to tgross35/rust that referenced this pull request Aug 21, 2024
@tgross35
Rollup merge of rust-lang#129332 - cuviper:cstr-cast, r=compiler-errors
54b3197 
Avoid extra `cast()`s after `CStr::as_ptr()`

These used to be `&str` literals that did need a pointer cast, but that
became a no-op after switching to `c""` literals in rust-lang#118566.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#129332 - cuviper:cstr-cast, r=compiler-errors
e961d6b 
Avoid extra `cast()`s after `CStr::as_ptr()`

These used to be `&str` literals that did need a pointer cast, but that
became a no-op after switching to `c""` literals in rust-lang#118566.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2024
@rust-timer
Unrolled build for rust-lang#129332
2368e5a 
Rollup merge of rust-lang#129332 - cuviper:cstr-cast, r=compiler-errors

Avoid extra `cast()`s after `CStr::as_ptr()`

These used to be `&str` literals that did need a pointer cast, but that
became a no-op after switching to `c""` literals in rust-lang#118566.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@klensy @rustbot @rust-log-analyzer @WaffleLapkin @bors @rust-timer @b-naber