[beta] Revert #117472: Stabilize C string literals #119528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0f41bc2.
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
O-unix
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
wesleywiser
changed the title
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-testsuite
This comment was marked as outdated.
This comment was marked as outdated.
|
Why revert #118566? Seems like a complex diff for no reason, just use a few |
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
revert_117472
branch
from
b1a5004 to
99aa435
Compare
Yeah, that's fair. The reverts were clean/trivial so that seemed slightly preferable to me but it's only a few lines to fix the feature gates. |
This comment has been minimized.
This comment has been minimized.
@wesleywiser Will you go forward with that alternative approach? I don't mind which way the revert happens, but this is somewhat time-sensitive so I don't want it to sit without progress for long. |
This was referenced Jan 8, 2024
12 tasks
ehuss
added a commit
to rust-lang/reference
that referenced
this pull request
Jan 9, 2024
This reverts commit 21a27e1, reversing changes made to 01a12f2. This is being reverted in rust-lang/rust#119528
ehuss
added a commit
to rust-lang/edition-guide
that referenced
this pull request
Jan 9, 2024
This reverts commit 5a4e7ba, reversing changes made to 34fca48. This is being reverted in rust-lang/rust#119528
wesleywiser
added
the
beta-nominated
bors
added
the
S-waiting-on-review
This comment was marked as spam.
This comment was marked as spam.
|
@bors retry timeout on dist-apple-various |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 10, 2024
…cote [beta] Revert rust-lang#117472: Stabilize C string literals Based on discussion in [#t-lang](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/rfc.203349.3A.20mixed.20utf8.20literals), revert the stabilization of C string literals in Rust 1.76. I also reverted rust-lang#118566 as it uses the newly stabilized C string literals in various places.
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry timeout on two apple runners |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rustbot
added
beta-accepted
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 12, 2024
…als, r=Nilstrieb Set `c_str_literals` stabilization version back to `CURRENT_RUSTC_VERSION` `c_str_literals`'s stabilization has been delayed to 1.77 (rust-lang#119528).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2024
Rollup merge of rust-lang#119865 - eduardosm:bump-version-c_str_literals, r=Nilstrieb Set `c_str_literals` stabilization version back to `CURRENT_RUSTC_VERSION` `c_str_literals`'s stabilization has been delayed to 1.77 (rust-lang#119528).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 12, 2024
…k-Simulacrum [Beta 1.77] Fix bootstrapping from 1.76 Due to the timing of the revert for stabilization of c_str_literal (rust-lang#119528 which reverted in 1.76) and trait_upcasting (rust-lang#120269 which reverted in 1.76), which happened after rust-lang#119211 (Bump stage0 to 1.76 beta), this resulted in some of the feature attributes not being restored which are needed to be able to bootstrap from 1.76. This restores those features. This also includes a stage0 bump to the just released stable. This is necessary because stage0 was currently pointing at an old beta which did not contain the reverts. Fixes rust-lang#120810
Tiger0202
added a commit
to Tiger0202/rust-lang
that referenced
this pull request
Dec 11, 2024
This reverts commit 21a27e16892fbdbec0c043c8c521b06e9174f6fd, reversing changes made to 01a12f22be9ff91edba38ebe982520cf19b86931. This is being reverted in rust-lang/rust#119528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #t-lang, revert the stabilization of C string literals in Rust 1.76.
I also reverted #118566 as it uses the newly stabilized C string literals in various places.