rustdoc ui: adjust tooltip z-index to be above sidebar #119477

lukas-code · 2023-12-31T19:41:16Z

In #115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again.

Fixes [after beta-backport] #119472.

rustbot · 2023-12-31T19:41:24Z

r? @notriddle

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-12-31T19:41:26Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

Some changes occurred in GUI tests.

cc @GuillaumeGomez

fmease · 2023-12-31T19:56:39Z

src/librustdoc/html/static/css/rustdoc.css

@@ -1046,7 +1046,7 @@ so that we can apply CSS-filters to change the arrow color in themes */
 	position: absolute;
 	top: 100%;
 	right: 0;
-	z-index: 2;
+	z-index: 101;


I know that we haven't done it like that for other z-indices but personally speaking I'd love to use CSS variables here to make this more robust. Something like

Suggested change

z-index: 101;

z-index: calc(var(--sidebar-z-index) + 1);

where we have defined --sidebar-z-index somewhere reasonable. Not sure what the other rustdoc reviewers think about that.

It'd even be self-documenting, too, that's a bonus.

This sounds like a good idea.

notriddle · 2024-01-01T05:06:32Z

@bors r+ rollup

bors · 2024-01-01T05:06:35Z

📌 Commit 0c6d43d has been approved by notriddle

It is now in the queue for this repository.

bors · 2024-01-01T05:06:36Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

and calculate the z-indices of things that go over the sidebar

lukas-code · 2024-01-01T14:50:22Z

I just realized that e306044 was incorrect and unintentionally changed the positioning of .hide-sidebar #sidebar-button.

Sorry for the noise, but this will need to be re-approved.

fmease · 2024-01-01T14:57:03Z

@bors r=notriddle

bors · 2024-01-01T14:57:06Z

📌 Commit b1853eb has been approved by notriddle

It is now in the queue for this repository.

bors · 2024-01-01T14:57:07Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

fmease · 2024-01-01T15:03:11Z

src/librustdoc/html/static/css/rustdoc.css

Btw, have you verified that flattening the z-index stack from (0, 2, 100, 101, 200) to just (0, 100, 101) doesn't incur further overlap regressions? @lukas-code

For the .sidebar-resizer i checked that it still looks correct for changing 200 to 101. The .popover going from 2 to 101 is exactly the bug this PR is trying to fix and I can't think of anything that's supposed to go over the popover at the moment.

Additionally, changing the resizer to 101 makes it appear below the popover, which seems more correct to me:

Alternatively it would look like this if we leave the resizer at 200:

Thanks for double-checking, your version does indeed look better.

Apparently this also affects the order of the settings/help popups and the sidebar while resizing the sidebar in a really narrow window. I don't know if this is relevant enough to add a special case.

before:

2024-01-01_16-40-09.mp4

after:

2024-01-01_16-40-24.mp4

Clicking the sidebar to resize it should just close the Settings popover. Make this whole discussion a moot point.

That's not important right now, though. I'll make a separate PR to fix this after it merges.

fmease · 2024-01-01T15:38:53Z

Nominating for beta-backport.
@rustbot label beta-nominated

fmease · 2024-01-01T22:37:15Z

Beta backport accepted as per rustdoc team on Zulip.
@rustbot label beta-accepted

…iddle rustdoc ui: adjust tooltip z-index to be above sidebar In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again. Fixes [after beta-backport] rust-lang#119472.

Rollup of 21 pull requests Successful merges: - rust-lang#119086 (Query panic!() to useful diagnostic) - rust-lang#119239 (Remove unnecessary arm in `check_expr_yield`) - rust-lang#119298 (suppress change-tracker warnings in CI containers) - rust-lang#119319 (Document that File does not buffer reads/writes) - rust-lang#119434 (rc: Take *const T in is_dangling) - rust-lang#119444 (Rename `TyCtxt::is_closure` to `TyCtxt::is_closure_or_coroutine`) - rust-lang#119474 (Update tracking issue of naked_functions) - rust-lang#119476 (Pretty-print always-const trait predicates correctly) - rust-lang#119477 (rustdoc ui: adjust tooltip z-index to be above sidebar) - rust-lang#119479 (Remove two unused feature gates from rustc_query_impl) - rust-lang#119487 (Minor improvements in comment on `freshen.rs`) - rust-lang#119492 (Update books) - rust-lang#119494 (Deny defaults for higher-ranked generic parameters) - rust-lang#119498 (Update deadlinks of `strict_provenance` lints) - rust-lang#119505 (Don't synthesize host effect params for trait associated functions marked const) - rust-lang#119510 (Report I/O errors from rmeta encoding with emit_fatal) - rust-lang#119512 (Mark myself as back from leave) - rust-lang#119514 (coverage: Avoid a query stability hazard in `function_coverage_map`) - rust-lang#119523 (llvm: Allow `noundef` in codegen tests) - rust-lang#119534 (Update `thread_local` examples to use `local_key_cell_methods`) - rust-lang#119544 (Fix: Properly set vendor in i686-win7-windows-msvc target) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119477 - lukas-code:tooltip-z-index, r=notriddle rustdoc ui: adjust tooltip z-index to be above sidebar In rust-lang#115660 the sidebar's z-index was changed to 100. This PR changes the tooltip's z-index to 101 to be above the sidebar again. Fixes [after beta-backport] rust-lang#119472.

Mark-Simulacrum · 2024-01-07T22:33:34Z

@lukas-code This does not backport cleanly (I think some prior PRs are perhaps missing?) -- please prepare a PR targeting current beta branch and cc me on it (happy to rubber stamp that).

Follow-up for rust-lang#119477 (comment)

[beta] rustdoc ui: adjust tooltip z-index to be above sidebar Backport of rust-lang#119477. Fixes rust-lang#119472. range-diff: ```range-diff 446: d796ad4 = 11: 53637cd rustdoc ui: adjust tooltip z-index to be above sidebar 459: b1853eb ! 12: c4c4ff6 use css variable for z-index of the sidebar `@@` src/librustdoc/html/static/css/rustdoc.css: so that we can apply CSS-filters to margin-top: 7px; border-radius: 3px; border: 1px solid var(--border-color); -`@@` src/librustdoc/html/static/css/rustdoc.css: a.tooltip:hover::after { - } - .src #sidebar-button { - left: 8px; -- z-index: 101; -+ z-index: calc(var(--desktop-sidebar-z-index) + 1); - } - .hide-sidebar .src #sidebar-button { - position: static; ``` The "show sidebar" button on the [source view page](https://doc.rust-lang.org/nightly/src/std/lib.rs.html) works differently on beta and nightly, but it is in fact above the sidebar in both versions. beta button: ![beta button](https://github.com/rust-lang/rust/assets/26522220/24d7e86f-d19e-452f-bef2-6b6004b42255) nightly button: ![nightly button](https://github.com/rust-lang/rust/assets/26522220/239dfdda-d9ca-4945-94dd-96254ed1c13f) cc `@Mark-Simulacrum`

…odals, r=fmease rustdoc: hide modals when resizing the sidebar Follow-up for rust-lang#119477 (comment) CC `@lukas-code`

Rollup merge of rust-lang#119746 - notriddle:notriddle/resize-close-modals, r=fmease rustdoc: hide modals when resizing the sidebar Follow-up for rust-lang#119477 (comment) CC `@lukas-code`

rustdoc ui: adjust tooltip z-index to be above sidebar

d796ad4

rustbot assigned notriddle Dec 31, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 31, 2023

fmease reviewed Dec 31, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2024

use css variable for z-index of the sidebar

b1853eb

and calculate the z-indices of things that go over the sidebar

lukas-code force-pushed the tooltip-z-index branch from 0c6d43d to b1853eb Compare January 1, 2024 14:47

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 1, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2024

fmease reviewed Jan 1, 2024

View reviewed changes

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 1, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 1, 2024

fmease mentioned this pull request Jan 2, 2024

Rollup of 13 pull requests #119516

Closed

This was referenced Jan 3, 2024

Rollup of 21 pull requests #119547

Closed

Rollup of 21 pull requests #119549

Merged

bors merged commit 493792b into rust-lang:master Jan 3, 2024
11 checks passed

rustbot added this to the 1.77.0 milestone Jan 3, 2024

lukas-code deleted the tooltip-z-index branch January 3, 2024 20:46

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 7, 2024

Mark-Simulacrum modified the milestones: 1.77.0, 1.76.0 Jan 7, 2024

Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 7, 2024

Mark-Simulacrum modified the milestones: 1.76.0, 1.77.0 Jan 7, 2024

lukas-code mentioned this pull request Jan 8, 2024

[beta] rustdoc ui: adjust tooltip z-index to be above sidebar #119743

Merged

notriddle added a commit to notriddle/rust that referenced this pull request Jan 8, 2024

rustdoc: hide modals when resizing the sidebar

2c5dd71

Follow-up for rust-lang#119477 (comment)

notriddle mentioned this pull request Jan 8, 2024

rustdoc: hide modals when resizing the sidebar #119746

Merged

notriddle added a commit to notriddle/rust that referenced this pull request Jan 8, 2024

rustdoc: hide modals when resizing the sidebar

8b52275

Follow-up for rust-lang#119477 (comment)

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2024

cuviper modified the milestones: 1.77.0, 1.76.0 Jan 11, 2024

This was referenced Jan 11, 2024

rustdoc UI: "This example is not tested" popup is below sidebar #119472

Closed

Expand upon PR guidelines rust-lang/rustc-dev-guide#1851

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc ui: adjust tooltip z-index to be above sidebar #119477

rustdoc ui: adjust tooltip z-index to be above sidebar #119477

lukas-code commented Dec 31, 2023 •

edited by fmease

Loading

rustbot commented Dec 31, 2023

rustbot commented Dec 31, 2023

fmease Dec 31, 2023

fmease Dec 31, 2023

notriddle Dec 31, 2023

notriddle commented Jan 1, 2024

bors commented Jan 1, 2024

bors commented Jan 1, 2024

lukas-code commented Jan 1, 2024 •

edited

Loading

fmease commented Jan 1, 2024

bors commented Jan 1, 2024

bors commented Jan 1, 2024

fmease Jan 1, 2024 •

edited

Loading

lukas-code Jan 1, 2024

fmease Jan 1, 2024

lukas-code Jan 1, 2024 •

edited

Loading

notriddle Jan 1, 2024 •

edited

Loading

fmease commented Jan 1, 2024

fmease commented Jan 1, 2024 •

edited

Loading

Mark-Simulacrum commented Jan 7, 2024

rustdoc ui: adjust tooltip z-index to be above sidebar #119477

rustdoc ui: adjust tooltip z-index to be above sidebar #119477

Conversation

lukas-code commented Dec 31, 2023 • edited by fmease Loading

rustbot commented Dec 31, 2023

rustbot commented Dec 31, 2023

fmease Dec 31, 2023

Choose a reason for hiding this comment

fmease Dec 31, 2023

Choose a reason for hiding this comment

notriddle Dec 31, 2023

Choose a reason for hiding this comment

notriddle commented Jan 1, 2024

bors commented Jan 1, 2024

bors commented Jan 1, 2024

lukas-code commented Jan 1, 2024 • edited Loading

fmease commented Jan 1, 2024

bors commented Jan 1, 2024

bors commented Jan 1, 2024

fmease Jan 1, 2024 • edited Loading

Choose a reason for hiding this comment

lukas-code Jan 1, 2024

Choose a reason for hiding this comment

fmease Jan 1, 2024

Choose a reason for hiding this comment

lukas-code Jan 1, 2024 • edited Loading

Choose a reason for hiding this comment

notriddle Jan 1, 2024 • edited Loading

Choose a reason for hiding this comment

fmease commented Jan 1, 2024

fmease commented Jan 1, 2024 • edited Loading

Mark-Simulacrum commented Jan 7, 2024

lukas-code commented Dec 31, 2023 •

edited by fmease

Loading

lukas-code commented Jan 1, 2024 •

edited

Loading

fmease Jan 1, 2024 •

edited

Loading

lukas-code Jan 1, 2024 •

edited

Loading

notriddle Jan 1, 2024 •

edited

Loading

fmease commented Jan 1, 2024 •

edited

Loading