Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] rustdoc ui: adjust tooltip z-index to be above sidebar #119743

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

lukas-code
Copy link
Member

@lukas-code lukas-code commented Jan 8, 2024

Backport of #119477.
Fixes #119472.

range-diff:

446:  d796ad4209b =  11:  53637cdd8ed rustdoc ui: adjust tooltip z-index to be above sidebar
459:  b1853eb3bd5 !  12:  c4c4ff67fae use css variable for z-index of the sidebar
    @@ src/librustdoc/html/static/css/rustdoc.css: so that we can apply CSS-filters to
        margin-top: 7px;
        border-radius: 3px;
        border: 1px solid var(--border-color);
    -@@ src/librustdoc/html/static/css/rustdoc.css: a.tooltip:hover::after {
    - }
    - .src #sidebar-button {
    -   left: 8px;
    --  z-index: 101;
    -+  z-index: calc(var(--desktop-sidebar-z-index) + 1);
    - }
    - .hide-sidebar .src #sidebar-button {
    -   position: static;

The "show sidebar" button on the source view page works differently on beta and nightly, but it is in fact above the sidebar in both versions.

beta button:
beta button

nightly button:
nightly button

cc @Mark-Simulacrum

Lukas Markeffsky added 2 commits January 8, 2024 14:15
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2024

r? @notriddle

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2024

Some changes occurred in GUI tests.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

Copy link
Contributor

@notriddle notriddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. Should I r+ it, or should someone on the release team do that?

@Mark-Simulacrum
Copy link
Member

@bors r=notriddle rollup=never

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit c4c4ff6 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2024
@bors
Copy link
Contributor

bors commented Jan 11, 2024

⌛ Testing commit c4c4ff6 with merge 7bcd95c...

@bors
Copy link
Contributor

bors commented Jan 11, 2024

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 7bcd95c to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 11, 2024
@bors bors merged commit 7bcd95c into rust-lang:beta Jan 11, 2024
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Jan 11, 2024
@lukas-code lukas-code deleted the beta-z-index branch January 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants