Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #120731

Closed
wants to merge 24 commits into from

Commits on Jan 16, 2024

  1. Add unstable -Z direct-access-external-data cmdline flag for rustc

    The new flag has been described in the Major Change Proposal at
    rust-lang/compiler-team#707
    heiher committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    06a4168 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    f38489e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1edc9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1031598 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    bae4f17 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Configuration menu
    Copy the full SHA
    8411eae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c9a64f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c80c836 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    16cbdd0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e65abc0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1a3214b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    411967c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6cac1c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Configuration menu
    Copy the full SHA
    a2ab48c View commit details
    Browse the repository at this point in the history
  2. Mark "unused binding" suggestion as maybe incorrect

    Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change.
    
    Fix rust-lang#54196.
    estebank committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    aef18c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    14dda5f View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#119162 - heiher:direct-access-external-data…

    …, r=petrochenkov
    
    Add unstable `-Z direct-access-external-data` cmdline flag for `rustc`
    
    The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#707
    
    Fixes rust-lang#118053
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4e54eea View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#119592 - petrochenkov:unload, r=compiler-er…

    …rors
    
    resolve: Unload speculatively resolved crates before freezing cstore
    
    Name resolution sometimes loads additional crates to improve diagnostics (e.g. suggest imports).
    Not all of these diagnostics result in errors, sometimes they are just warnings, like in rust-lang#117772.
    
    If additional crates loaded speculatively stay and gets listed by things like `query crates` then they may produce further errors like duplicated lang items, because lang items from speculatively loaded crates are as good as from non-speculatively loaded crates.
    They can probably do things like adding unintended impls from speculatively loaded crates to method resolution as well.
    The extra crates will also get into the crate's metadata as legitimate dependencies.
    
    In this PR I remove the speculative crates from cstore when name resolution is finished and cstore is frozen.
    This is better than e.g. filtering away speculative crates in `query crates` because things like `DefId`s referring to these crates and leaking to later compilation stages can produce ICEs much easier, allowing to detect them.
    
    The unloading could potentially be skipped if any errors were reported (to allow using `DefId`s from speculatively loaded crates for recovery), but I didn't do it in this PR because I haven't seen such cases of recovery. We can reconsider later if any relevant ICEs are reported.
    
    Unblocks rust-lang#117772.
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0a8908b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120103 - compiler-errors:concrete-afits, r=…

    …oli-obk
    
    Make it so that async-fn-in-trait is compatible with a concrete future in implementation
    
    There's no technical reason why an AFIT like `async fn foo()` cannot be satisfied with an implementation signature like `fn foo() -> Pin<Box<dyn Future<Output = ()> + 'static>>`.
    
    We rejected this previously because we were uncertain about how AFITs worked with refinement, but I don't believe this needs to be a restriction any longer.
    
    r? oli-obk
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ce877d2 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#120455 - JarlEvanson:sroa-miri-tests, r=cjg…

    …illot
    
     Add FileCheck annotations to MIR-opt SROA tests
    
    Part of rust-lang#116971, adds FileCheck annotations to SROA MIR-opt tests in `tests/mir-opt/sroa` and a few uncategorized files.
    
    r? cjgillot
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    8bdae44 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120470 - estebank:issue-54196, r=compiler-e…

    …rrors
    
    Mark "unused binding" suggestion as maybe incorrect
    
    Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change.
    
    Fix rust-lang#54196.
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    35c92ad View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120619 - compiler-errors:param, r=lcnr

    Assert that params with the same *index* have the same *name*
    
    Found this bug when trying to build libcore with the new solver, since it will canonicalize two params with the same index into *different* placeholders if those params differ by name.
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5407d3b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120633 - Nadrieril:place_info, r=compiler-e…

    …rrors
    
    pattern_analysis: gather up place-relevant info
    
    We track 3 things about each place during exhaustiveness: its type, its (data) validity, and whether it's the scrutinee place. This PR gathers all three into a single struct.
    
    r? ```@compiler-errors```
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    18ff926 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#120726 - saethlin:no-bashism, r=Mark-Simula…

    …crum
    
    Don't use bashism in checktools.sh
    
    `if [[` doesn't work because this is a `/bin/sh` script. We were never running the success side of this `if` at all.
    matthiaskrgr authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    8924c26 View commit details
    Browse the repository at this point in the history