Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree update of rust-analyzer #123258

Merged
merged 145 commits into from
Mar 31, 2024
Merged

Subtree update of rust-analyzer #123258

merged 145 commits into from
Mar 31, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Mar 31, 2024

No description provided.

Jesse-Bakker and others added 30 commits March 13, 2024 18:02
fix: Ignore some warnings if they originate from within macro expansions

These tend to be annoying noise as we can't handle `allow`s for them properly for the time being.
Bump dependencies and use in-tree `rustc_pattern_analysis`

One last `pattern_analysis` API change. I don't have any more planned! So we can now use the in-tree version when available.
fix: handle attributes when typing curly bracket

fix rust-lang#16848.

When inserting a `{`, if it is identified that the front part of `expr` is `attr`, we consider it as inserting `{}` around the entire `expr` (excluding the attr part).
…illa

Fix panic with impl trait associated types in where clause

Not sure if this is the correct fix, but the tests are green :')

Fixes rust-lang#16823
… r=Veykril

Refactor extension to support arbitrary shell command runnables

Currently, the extension assumes that all runnables invoke cargo. Arguments are sometimes full CLI arguments, and sometimes arguments passed to a cargo subcommand.

Refactor the extension so that tasks are just a `program` and a list of strings `args`, and rename `CargoTask` to `RustTask` to make it generic.

(This was factored out of rust-lang#16135 and tidied.)
fix: Make inlay hint resolving work better for inlays targetting the same position
lnicola and others added 14 commits March 28, 2024 07:58
fix: use lldb when debugging with C++ extension on MacOS

See rust-lang/rust-analyzer#16901 (comment)

This PR resolves the issue of being unable to debug using the C++ extension on macOS. By using special configurations for the `MIMode` on macOS, it enables the C++ extension to connect to lldb when debugging (without affecting other platforms).
…lnicola

fix: check for client support of relative glob patterns before using them

Fixes rust-lang#16955
fix: ADT hover considering only type or const len not lifetimes

I feel like test doesn't do much. Please suggest if I should improve it?

Fixes rust-lang#16963
Resolve tests per file instead of per crate in test explorer

Fix part of rust-lang#16827
…lnicola

refactor: Implement len and is_empty method in generic_params
Prompt the user to reload the window when enabling test explorer
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2024
@lnicola
Copy link
Member Author

lnicola commented Mar 31, 2024

@bors r+ p=1 subtree sync

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit a4e02d7 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2024
@bors
Copy link
Contributor

bors commented Mar 31, 2024

⌛ Testing commit a4e02d7 with merge 688c30d...

@bors
Copy link
Contributor

bors commented Mar 31, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 688c30d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2024
@bors bors merged commit 688c30d into rust-lang:master Mar 31, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
@lnicola lnicola deleted the sync-from-ra branch March 31, 2024 11:18
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (688c30d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.013s -> 669.42s (0.36%)
Artifact size: 315.73 MiB -> 315.72 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.